Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address the issue #179 - fix building native image with the MongoDB #180

Merged
merged 5 commits into from
Mar 26, 2021
Merged

Address the issue #179 - fix building native image with the MongoDB #180

merged 5 commits into from
Mar 26, 2021

Conversation

vektory79
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2021

CLA assistant check
All committers have signed the CLA.

@vektory79
Copy link
Contributor Author

Seems like more investigation needed to find the way to adding migration scripts to the reflection configs.

@vektory79
Copy link
Contributor Author

#179 - adding support of the Mongock for native image

@avdev4j
Copy link
Contributor

avdev4j commented Mar 24, 2021

Hey @vektory79
I've tested it and it sounds good. Could you please just update the generator tests (inside the test folder) when we choose Mongo. Then I will merge this PR.
https://github.com/jhipster/generator-jhipster-quarkus/blob/main/test/server.spec.js#L351

https://github.com/jhipster/generator-jhipster-quarkus/blob/main/test/utils/expected-files.js#L103

@vektory79
Copy link
Contributor Author

Something weird happens here. I can't understand what thing breaking all of the tests. :(

@avdev4j
Copy link
Contributor

avdev4j commented Mar 25, 2021

yes, I've just figured out the Ci is using the last JHipster version instead of the good one. Since JHi7 has been released it makes it failed.

I will try to get a look tomorrow and fix that.

@avdev4j
Copy link
Contributor

avdev4j commented Mar 26, 2021

I fixed it @vektory79 through #181

let's try to run the CI again

@avdev4j avdev4j closed this Mar 26, 2021
@avdev4j avdev4j reopened this Mar 26, 2021
@vektory79
Copy link
Contributor Author

Yoohoo! It's done :)

@sonarcloud
Copy link

sonarcloud bot commented Mar 26, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@avdev4j avdev4j merged commit edbb207 into jhipster:main Mar 26, 2021
@avdev4j
Copy link
Contributor

avdev4j commented Mar 26, 2021

Thanks for your contribution @vektory79

Don't forget to claim your bounty and put the link in this PR so we can validate it.

See you soon on JHipster Quarkus!

@vektory79
Copy link
Contributor Author

@pascalgrimaud
Copy link
Member

@vektory79 : approved

@vektory79 vektory79 deleted the mongock-native-image-support branch March 27, 2021 15:51
@dieppa
Copy link

dieppa commented May 24, 2021

I already made this comment in another ticket related to this, but I just reproduce it again:

I have just realised about this ticket and it seems that has been somehow sorted out.

However is there anything that we can provide natively from Mongock to help on this or improve.

Just us me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants