Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize JHipster 7 features. #224

Merged
merged 10 commits into from
Aug 24, 2021
Merged

Customize JHipster 7 features. #224

merged 10 commits into from
Aug 24, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented Aug 21, 2021

  • Change user api endpoint from /api/users to /api/admin/users.
  • Rename jdl samples from .jh to .jdl
  • Reformat workflows to tabWith 2 to match jhipster main repository format.
  • Add cypress to samples, disable failing tests.
  • Customize package.json scripts.

related to #223

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@avdev4j
Copy link
Contributor

avdev4j commented Aug 23, 2021

not sure to understand why we need to change the users endpoint.
I plan to do a new beta release including JHipster 7, I guess this one should be included.

@mshima
Copy link
Member Author

mshima commented Aug 23, 2021

@avdev4j do you prefer to change the client endpoint instead?

@avdev4j
Copy link
Contributor

avdev4j commented Aug 24, 2021

as I understand we changed the endpoints generated by JHipster and now we have 2 solutions:

  • changing the Quarkus code to expose the same endpoints
  • changing the frontend to reach the old one

If this is it, I'd rather like to change the endpoint in the backend. JHipster Quarkus is a "backend" blueprint, if we can avoid changing the frontend, it's better.

@mshima
Copy link
Member Author

mshima commented Aug 24, 2021

as I understand we changed the endpoints generated by JHipster

Yes.

If this is it, I'd rather like to change the endpoint in the backend. JHipster Quarkus is a "backend" blueprint, if we can avoid changing the frontend, it's better.

That’s it.

@avdev4j
Copy link
Contributor

avdev4j commented Aug 24, 2021

Great! So let's merge this one, if it's ready.

@mshima
Copy link
Member Author

mshima commented Aug 24, 2021

I don’t have commit rights.

@avdev4j avdev4j merged commit 52167ce into jhipster:main Aug 24, 2021
@mshima mshima deleted the jhipster7 branch June 9, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants