Run cypress test at workflow. #225

mshima · 2021-08-21T02:33:53Z

Draft a custom test with cypress.
Disabled 2 tests to succeed for 1 test to succeed.

Broken:

imperative-ngx-jwt-maven-mysql-caffeine: mysql problem
imperative-react-jwt-gradle-mysql-caffeine: gradle bootJar
imperative-ngx-oauth2-maven-mysql-caffeine: 'quarkus.oidc.client-id' property must be configured
h2 + maven
Relationship with Users need to add /api/user.

sonarcloud · 2021-08-24T12:56:40Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

mraible · 2022-10-21T17:56:10Z

@mshima Is this still needed?

mshima · 2022-10-21T17:59:47Z

@mraible I don't think it has been implemented, it's nice to have.
See #250.

mshima · 2022-10-21T18:00:20Z

Reopened to create a new merge point.

mshima · 2022-10-21T19:27:32Z

3 of 7 tests are passing if the account register is disabled.
The MongoDB test is failing with:

io.quarkus.hibernate.validator.runtime.interceptor.AbstractMethodValidationInterceptor.validateMethodInvocation(AbstractMethodValidationInterceptor.java:71)

Looks like its using hibernate??

vishal423 · 2022-10-21T20:07:15Z

3 of 7 tests are passing if the account register is disabled.

Any specific reason for that?

The MongoDB test is failing with:

io.quarkus.hibernate.validator.runtime.interceptor.AbstractMethodValidationInterceptor.validateMethodInvocation(AbstractMethodValidationInterceptor.java:71)

Looks like its using hibernate??

That's just Validator. Actual cause could be mismatch in impl vs expectation.

Another point I remember about OIDC flow is that it requires a minor override in cypress login command to redirect post authentication ( at least for Keycloak). There are other open issues like missing authorities endpoint, missing roles etc that require closure before achieving a green state.

mshima · 2022-10-21T21:37:12Z

Any specific reason for that?

Disable account register?
It's broken for every workflow.

mshima · 2022-10-21T22:03:53Z

For oauth2 we could try to migrate to ui login.

vishal423 · 2022-10-22T09:50:38Z

Any specific reason for that?

Disable account register? It's broken for every workflow.

Did you try with latest code?

vishal423 · 2022-10-22T10:00:47Z

For oauth2 we could try to migrate to ui login.

I haven't observed much issues with login post initial implementation. We can try login with UI (with all providers), however that should be done on JHipster side and not over here. For current issue, the change is at a single place to redirect (current conf is to not do that)

vishal423 · 2022-10-22T10:04:55Z

https://github.com/jhipster/generator-jhipster/blob/1ec2ebbe7fb7fb147654369d9f9164ca6c2e6553/generators/cypress/templates/src/test/javascript/cypress/support/oauth2.ts.ejs#L59

mshima · 2022-10-22T10:07:36Z

Any specific reason for that?

Disable account register? It's broken for every workflow.

Did you try with latest code?

Sure https://github.com/jhipster/generator-jhipster-quarkus/actions/runs/3299590773 (last but one commit)

With account registration disabled https://github.com/jhipster/generator-jhipster-quarkus/actions/runs/3299677293 (last commit)

vishal423 · 2022-11-12T13:55:51Z

.github/workflows/smoke-test-imperative-compare.yml

+    strategy:
+      fail-fast: false
+      matrix:
+        node_version: [14.16.0]


should update to align with supported node version

Sure, at jhipster we read from constants now.

vishal423 · 2022-11-12T13:58:30Z

.github/workflows/smoke-test-imperative-compare.yml

+          - app: imperative-sql-jwt-maven-no-db
+          - app: imperative-ngx-oauth2-maven-mysql-caffeine
+        exclude:
+          - app: imperative-ngx-jwt-gradle-mongodb-redis


If the exclusion is due to some failures, then, please log an issue so that it can be looked into and fixed

It's excluded from main workflow too. That's the reason.

vishal423 · 2022-11-12T14:04:18Z

.github/workflows/smoke-test-imperative-compare.yml

+      - name: 'SETUP: Checkout generator-jhipster'
+        uses: actions/checkout@v2
+        with:
+          repository: 'jhipster/generator-jhipster'


It seems we are relying on the main branch of JHipster. I suggest to rely on the current supported JHipster version i.e. v7.9.3 to avoid any surprises.

Yes. It should be version specific.

vishal423 · 2022-11-12T14:29:01Z

generators/cypress/index.js

+    get postWriting() {
+        return {
+            customize() {
+                /*


please remove commented code block

vishal423 · 2022-11-12T14:29:26Z

generators/cypress/index.js

+                    "it.skip('should be able to init reset password'"
+                );
+                */
+                this.replaceContent(


I will take a look into registration test failure. Can you remove this hack?

Sure, fell free to change the PR or create a branch in the this repository as you wish.

vishal423 · 2022-11-12T14:35:09Z

.github/workflows/smoke-test-imperative-compare.yml

+        with:
+          path: generator-jhipster-quarkus
+          fetch-depth: 5
+      - name: git history


Displaying git history in CI seems just clutter and not much useful. Can we remove it?

I think it can be dropped.

vishal423 · 2022-11-12T14:38:14Z

.github/workflows/smoke-test-imperative-compare.yml

+        id: compare
+        if: steps.base-app.outcome == 'success'
+        uses: ./generator-jhipster/.github/actions/compare
+      - name: 'Backend diff with updated prettier'


Why do we need this step?

v6 -> v7 was complicated and all files changed due to prettier changes.
It was temporary added for this purpose. Can be dropped.

vishal423 · 2022-11-12T14:38:54Z

.github/workflows/smoke-test-imperative-compare.yml

@@ -0,0 +1,124 @@
+name: Imperative Smoke Tests Compare


Instead of having two CI workflows executing similar tests, can we enrich existing CI tests to add compare functionality and to run the e2e tests?

I don’t recall exactly why, but they were temporary created for different purposes for the v6 -> v7 migration.

sonarcloud · 2022-11-13T01:30:40Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

mshima added 3 commits August 20, 2021 23:14

Implement cypress generator and disable a failing test..

8e3357d

Add smoke-test-imperative-compare workflow

22f6812

Merge branch 'jhipster:main' into workflow

ffa192b

mshima mentioned this pull request Sep 14, 2021

Add custom cli to actions for blueprints. jhipster/generator-jhipster#16295

Merged

6 tasks

vishal423 mentioned this pull request Oct 13, 2022

Enhance CI workflows to execute cypress e2e tests #250

Closed

mshima closed this Oct 21, 2022

mshima reopened this Oct 21, 2022

mshima added 4 commits October 21, 2022 15:02

Update smoke-test-imperative-compare.yml

768ec2b

update cypress file extension

5a0048e

Merge branch 'jhipster:main' into workflow

41c1322

fix cypress file name

3b748dc

mshima added 2 commits October 22, 2022 07:12

enable redirection for oauth2

6c9be88

Update index.js

7f62eae

vishal423 mentioned this pull request Oct 30, 2022

Release 2.0 version of this blueprint #256

Closed

vishal423 reviewed Nov 12, 2022

View reviewed changes

vishal423 mentioned this pull request Nov 12, 2022

Analyse and fix registration flow cypress test failures #259

Closed

mshima added 2 commits November 12, 2022 22:28

adjusts to the workflow

b1a2e08

drop cypress customizations.

413c9bb

fix cypress

72209b9

mshima mentioned this pull request Nov 13, 2022

Improve workflow #260

Merged

vishal423 closed this in #260 Nov 14, 2022

mshima deleted the workflow branch June 10, 2024 01:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run cypress test at workflow. #225

Run cypress test at workflow. #225

mshima commented Aug 21, 2021

sonarcloud bot commented Aug 24, 2021

mraible commented Oct 21, 2022

mshima commented Oct 21, 2022

mshima commented Oct 21, 2022

mshima commented Oct 21, 2022

vishal423 commented Oct 21, 2022

mshima commented Oct 21, 2022

mshima commented Oct 21, 2022

vishal423 commented Oct 22, 2022

vishal423 commented Oct 22, 2022

vishal423 commented Oct 22, 2022

mshima commented Oct 22, 2022

vishal423 Nov 12, 2022

mshima Nov 12, 2022

vishal423 Nov 12, 2022

mshima Nov 13, 2022

vishal423 Nov 12, 2022

mshima Nov 12, 2022

vishal423 Nov 12, 2022

vishal423 Nov 12, 2022

mshima Nov 12, 2022

vishal423 Nov 12, 2022

mshima Nov 12, 2022

vishal423 Nov 12, 2022

mshima Nov 12, 2022

vishal423 Nov 12, 2022

mshima Nov 12, 2022

sonarcloud bot commented Nov 13, 2022

Run cypress test at workflow. #225

Run cypress test at workflow. #225

Conversation

mshima commented Aug 21, 2021

sonarcloud bot commented Aug 24, 2021

mraible commented Oct 21, 2022

mshima commented Oct 21, 2022

mshima commented Oct 21, 2022

mshima commented Oct 21, 2022

vishal423 commented Oct 21, 2022

mshima commented Oct 21, 2022

mshima commented Oct 21, 2022

vishal423 commented Oct 22, 2022

vishal423 commented Oct 22, 2022

vishal423 commented Oct 22, 2022

mshima commented Oct 22, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarcloud bot commented Nov 13, 2022