Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Prepare next release v2.0.0 #283

Merged
merged 3 commits into from
Mar 31, 2023

Conversation

vishal423
Copy link
Collaborator

  • GitHub Actions workflow to auto publish new npm package. It requires someone with admin access to configure npm token under NPM_TOKEN GITHUB secret.
  • Update package version to 2.0.0

@vishal423
Copy link
Collaborator Author

@pascalgrimaud, do we have an org wise NPM_TOKEN added under secrets for npm releases? I don't have admin access on this repository, so, can't add mine to do a new release.

@pascalgrimaud
Copy link
Member

@vishal423 : no we don't have it because for publishing to NPM, you need an OTP, so the NPM_TOKEN doesn't work

@vishal423
Copy link
Collaborator Author

@vishal423 : no we don't have it because for publishing to NPM, you need an OTP, so the NPM_TOKEN doesn't work

@pascalgrimaud , I don't think 2FA is applicable over here. svelte blueprint is configured with similar token (my personal) and that used to work fine. Can you add me to admins group so that I can try adding over here as well?

@pascalgrimaud
Copy link
Member

@vishal423 : just added you in admin quarkus team, so you can give a try

Maybe it's because the project doesn't belong to JHipster NPM organization

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vishal423 vishal423 marked this pull request as ready for review March 31, 2023 19:19
@vishal423 vishal423 merged commit aeba6c9 into jhipster:main Mar 31, 2023
@vishal423 vishal423 deleted the release-github-ci branch March 31, 2023 19:19
@vishal423
Copy link
Collaborator Author

@pascalgrimaud , npm auto publish seems to fail due to access denied. Can you please include my name to the allowed list of contributors on npm side?

@pascalgrimaud
Copy link
Member

@vishal423 : done

@vishal423
Copy link
Collaborator Author

vishal423 commented Apr 1, 2023 via email

@vishal423
Copy link
Collaborator Author

@pascalgrimaud
Copy link
Member

@vishal423 : approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants