Skip to content

Commit

Permalink
enable expo install --check test ignoring expo (#1909)
Browse files Browse the repository at this point in the history
* Revert "drop expo install --check (#1817)"

This reverts commit 2e6adda.

* configure expo install command to ignore expo package

* Update package.json

* Update package.json
  • Loading branch information
mshima authored Oct 2, 2024
1 parent c79a1a8 commit 0c6ba98
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 2 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/generator.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,7 @@ jobs:
run: npm ci
- name: lint and test
run: npm run test
- name: check-dependencies
run: |
cd generators/react-native/resources/expo
npm run check-dependencies
15 changes: 15 additions & 0 deletions .github/workflows/ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,23 @@ concurrency:
# Cancel intermediate pull request builds
cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }}
jobs:
check-dependencies:
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, '[ci skip]') && !contains(github.event.head_commit.message, '[skip ci]') && !contains(github.event.pull_request.title, '[skip ci]') && !contains(github.event.pull_request.title, '[ci skip]') && !contains(github.event.ref_type, '[tag]')"
timeout-minutes: 5
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 20
- name: check-dependencies
run: |
cd generators/react-native/resources/expo
npm run check-dependencies
build-matrix:
runs-on: ubuntu-latest
needs: [check-dependencies]
outputs:
matrix: ${{ steps.build.outputs.matrix }}
steps:
Expand Down
11 changes: 9 additions & 2 deletions generators/react-native/resources/expo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@
"expo-web-browser": "~13.0.3",
"react": "18.2.0",
"react-dom": "18.2.0",
"react-native": "0.74.2",
"react-native": "0.74.5",
"react-native-gesture-handler": "~2.16.2",
"react-native-reanimated": "~3.10.1",
"react-native-safe-area-context": "4.10.1",
"react-native-safe-area-context": "4.10.5",
"react-native-screens": "3.31.1",
"react-native-web": "~0.19.12"
},
Expand All @@ -38,5 +38,12 @@
"@types/react": "~18.2.79",
"jest-expo": "~51.0.2",
"typescript": "~5.3.3"
},
"expo": {
"install": {
"exclude": [
"expo"
]
}
}
}

0 comments on commit 0c6ba98

Please sign in to comment.