Skip to content

Commit

Permalink
upgrade typescrript fix #6051
Browse files Browse the repository at this point in the history
  • Loading branch information
deepu105 committed Jul 15, 2017
1 parent 0d7f0a5 commit 5088911
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
8 changes: 4 additions & 4 deletions generators/client/templates/angular/_package.json
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
<%_ } _%>
"tslint": "5.5.0",
"tslint-loader": "3.5.3",
"typescript": "2.3.4",
"typescript": "2.4.1",
<%_ if (useSass) { _%>
"sass-loader": "6.0.6",
"node-sass": "4.5.3",
Expand All @@ -133,8 +133,8 @@
"node": ">=6.9.0"
},
"scripts": {
"lint": "tslint '<%= MAIN_SRC_DIR%>app/**/*.ts' '<%= TEST_SRC_DIR%>**/*.ts'",
"lint:fix": "tslint '<%= MAIN_SRC_DIR%>app/**/*.ts' '<%= TEST_SRC_DIR%>**/*.ts' --fix",
"lint": "tslint --type-check --project './tsconfig.json' -e 'node_modules/**'",
"lint:fix": "<%= clientPackageManager %> run lint -- --fix",
"ngc": "ngc -p tsconfig-aot.json",
"cleanup": "rimraf <%= BUILD_DIR %>{aot,www}",
"start": "<%= clientPackageManager %> run webpack:dev",
Expand All @@ -147,7 +147,7 @@
"webpack-dev-server": "node --max_old_space_size=4096 node_modules/webpack-dev-server/bin/webpack-dev-server.js",
"webpack": "node --max_old_space_size=4096 node_modules/webpack/bin/webpack.js",
"test": "karma start src/test/javascript/karma.conf.js",
"test:watch": "karma start src/test/javascript/karma.conf.js --watch",
"test:watch": "<%= clientPackageManager %> test -- --watch",
<%_ if (protractorTests) { _%>
"e2e": "protractor <%= TEST_SRC_DIR %>protractor.conf.js",
"postinstall": "webdriver-manager update && node node_modules/phantomjs-prebuilt/install.js"
Expand Down
1 change: 1 addition & 0 deletions generators/client/templates/angular/_tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
"experimentalDecorators": true,
"removeComments": false,
"noImplicitAny": false,
"skipLibCheck": true,
"suppressImplicitAnyIndexErrors": true,
"outDir": "<%= DIST_DIR %>app",
"lib": ["es6", "dom"],
Expand Down

2 comments on commit 5088911

@stieler-it
Copy link
Contributor

@stieler-it stieler-it commented on 5088911 Aug 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @deepu105, while upgrading to 4.6.2 we wondered why skipLibCheck is necessary. Is it broken for some reason?

Edit: Ok, I found out, it's a workaround for the new typescript version a suggested here

@deepu105
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stieler-it yes, else some of the libraries(including angular) fail type check and there is nothing we could do about it

Please sign in to comment.