Skip to content

Commit

Permalink
fix: changes as required per the code review
Browse files Browse the repository at this point in the history
  • Loading branch information
SudharakaP committed Dec 7, 2023
1 parent bfb1cb1 commit bcef48c
Showing 1 changed file with 20 additions and 19 deletions.
39 changes: 20 additions & 19 deletions .github/workflows/linked-issue-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
runs-on: ubuntu-latest
permissions:
issues: read
pull-requests: write
pull-requests: read
outputs:
linked-issues: ${{ steps.get-linked-issues.outputs.issues }}
linked-issues-count: ${{ steps.get-linked-issues.outputs.linked_issues_count }}
Expand All @@ -37,7 +37,8 @@ jobs:
with:
custom-body-comment: 'This PR is not linked to any issues. Please consider adding the corresponding issues if they exist, in the pull request description.'
continue-on-error: true
generate-project:
closing-issues:
name: ${{ matrix.linked-issue }}
strategy:
fail-fast: false
matrix:
Expand All @@ -56,28 +57,15 @@ jobs:
uses: actions/checkout@v4
with:
path: generator-jhipster
fetch-depth: 2
- name: 'SETUP: environment'
id: setup
uses: ./generator-jhipster/.github/actions/setup
- uses: actions/setup-node@v4
with:
node-version: ${{ steps.setup.outputs.node-version }}
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: ${{ steps.setup.outputs.java-version }}
fetch-depth: 1
- uses: ./generator-jhipster/.github/actions/setup-default-node-java
- uses: jhipster/actions/restore-cache@v0
with:
npm: true
maven: true
gradle: true
- name: 'TOOLS: configure tools installed by the system'
run: $JHI_SCRIPTS/03-system.sh
- name: 'TOOLS: configure git'
run: $JHI_SCRIPTS/04-git-config.sh
- name: 'Install required NPM version'
run: npm install -g npm@${{ steps.setup.outputs.npm-version }} || true
- uses: jhipster/actions/setup-keycloak-hostname@v0
- uses: jhipster/actions/setup-git@v0
#----------------------------------------------------------------------
# Install JHipster and generate project+entities
#----------------------------------------------------------------------
Expand Down Expand Up @@ -127,3 +115,16 @@ jobs:
- name: Dump docker logs
if: always()
uses: jwalton/gh-docker-logs@v2
check-closing-issues:
permissions:
contents: none
runs-on: ubuntu-latest
needs: [ closing-issues ]
if: always()
steps:
- run: |
echo '${{ toJSON(needs) }}'
if [ 'skipped' == '${{ needs.closing-issues.result }}' ] || [ 'success' == '${{ needs.closing-issues.result }}' ] || [ 'closed' == '${{ github.event.action }}' ]; then
exit 0
fi
exit 12

0 comments on commit bcef48c

Please sign in to comment.