[Feature] Official support for Yarn

[deepu105]

The discussion started here

So people from FB, Google, Tilde etc have joinly released Yarn (read npm killer)

• So for people who are frustrated with npm can just start using Yarn without needing to do any changes to your package.json in generated projects and generator itself. we dont have to do anything specific here (May be we can mention this in our docs)
• This seems to work for a generated app (I tested only the angular2 branch, but should work on master as well) there are few minor quirks though
  1. Optional dependencies not met yarnpkg/yarn#628 (you need to run yarn add <lib-name> --dev for [imagemin-svgo, imagemin-jpegtran, imagemin-optipng, imagemin-gifsicle] as workaround)
  2. Package install fails on first try, success on second try consistently for many package yarnpkg/yarn#820 (just run add command again)
     So once this is stable we can may be check if yarn is present and then trigger yarn install instead of npm install post app generation, as its way way way faster. npm install can be fallback for people who ahve not installed yarn
• Another step is to use yarn for our travis build as it would reduce run times greatly

@jhipster/developers what do you think, also it would be great if some of you can test this out on mac and linux

I would like to do some performance benchmark but im on a slow mobile network now so not sure if its ideal. So if someone on fast connection can benchmark that would be great

[sendilkumarn]

@deepu105 as discussed in mail thread.
it took 80 sec to install everything for angular2 repo.

[sendilkumarn]

no need of yarn install --> yarn would do

[deepu105]

Yes I know, its just for consistency similar to we doing npm install where npm i would be sufficient

[deepu105]

@sendilkumarn could you do a benchmark?

• create a fresh project
• run npm install (measure actual time taken)
• run npm install again (measure actual time taken)
• delete the node_modules folder
• run yarn (measure actual time taken not the one printed by yarn as its less than actual)
• run yarn again (measure actual time taken not the one printed by yarn as its less than actual)

[PierreBesson]

I'm all for supporting yarn when it is detected as globally installed. Yarm looks very promising and it's very simple to switch to it !
Let's try it first on Travis so that we can detect bugs if there are any...

[deepu105]

@PierreBesson as soon as yarnpkg/yarn#789 is merged and released we can try it for our travis

[sendilkumarn]

Npm install
first time - 3.19.65 ~ 200s
second time - 0.15.10 ~ 15s
Yarn install
first time - 1.10.69 ~ 71s
second time - 0.00.25 ~ 0.25s

@deepu105 the time is equal to what they show 😛

[cbornet]

For a generator such as JHipster, this is a killer improvement !

[PierreBesson]

On my machine (Macbook) measured using "time":

• First npm install: 48.01s
• Second npm install: 8.67s
• rm node_modules
• First yarn 28.78s
• Second yarn 0.35s

[wmarques]

On mine:

• First npm i: 2m52.883s
• Second npm i : 20.637s
• removed node_modules
• First yarn: 1m2.255s
• second yarn: 0.29s.

[sendilkumarn]

lets roll out yarn then.

[cbornet]

For yarnpkg/yarn#789, maybe a workaround until the release:

In the meantime, adding the following to .yarnrc fixed the problem for me:
ignore-optional false

[deepu105]

For a generated project this issue would be blocking yarnpkg/yarn#616
workaround is to run bower install after yarn install completes
For the generator and travis we can ofcourse try

[pascalgrimaud]

I will test with our current Travis build

[edit] after some tries, I think I will wait the issue on yarn resolved 😪

[MathieuAA]

Hey guys, they only had 1.3K stars 3 days ago, now they have 13K... that's crazy!

[deepu105]

Big companies, lots of hype, more marketing and lots of frustrated npm
users :P

Thanks & regards,
Deepu

On 15 Oct 2016 01:04, "Mathieu ABOU-AICHI" notifications@github.com wrote:

Hey guys, they only had 1.3K stars 3 days ago, now they have 13K... that's
crazy!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4317 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABDlF_QuKzWhu7FXX31QBfaQ3n-xuw5iks5qz9lIgaJpZM4KUctC
.

[PierreBesson]

We should be able to switch to yarn now that @sendilkumarn 's PR is merged and released upstream: https://github.com/yarnpkg/yarn/releases/tag/v0.16.0
Congrats Sendil !

[MathieuAA]

Not yet... yarn's support is not widely "on" right now (check TravisCi PR about it here for instance). If you guys wanna use it, you can as it's on top of NPM but don't expect to see big differences... it's the opposite right now (check JHipster Core's yarn-dedicated branch, or better this). Too much hype kills the hype (but not the hipster :)).

[pascalgrimaud]

Like @MathieuAA said, let's wait.
Yarn is not stable yet and it's not so easy to make it work with Travis.

Here what I tried:

• 1st build without cache : all ok
• 2nd build using the existing cache: fail with PhantomJS

I have one question: what is the equivalent of npm test ?

[MathieuAA]

yarn run test... they haven't exposed everything yet.

[MathieuAA]

You can see every command here.... but I've yet to see a project fully support the bare minimum as people do with NPM.

[pascalgrimaud]

Thanks Matthieu! The last time I look, I didn't see it...

[deepu105]

yes lets wait

[pascalgrimaud]

I play with yarn since 0.16.1 and it seems working very well.
So for all projects generated, I use:

yo jhipster --skip-install
yarn && bower install && gulp install

What do you think about adding --yarn option?
The use will be: yo jhipster --yarn -> with this, the generator will do yarn install instead of npm install

I have this code already working on my branch, tell me if I should PR or not?
It should be a first step for supporting yarn in our generator without breaking the current behavior

[jdubois]

Oh yes that would be cool!!!
We need this for our Devoxx presentation on Monday, with the bad Wifi!!
I would even add a new question for this.

Le 3 nov. 2016 7:35 PM, "Pascal Grimaud" notifications@github.com a
écrit :

I play with yarn since 0.16.1 and it seems working very well.
So for all projects generated, I use:

yo jhipster --skip-install
yarn && bower install && gulp install

What do you think about adding --yarn option?
The use will be: yo jhipster --yarn -> with this, the generator will do yarn
install instead of npm install

I have this code already working on my branch, tell me if I should PR or
not?
It should be a first step for supporting yarn in our generator without
breaking the current behavior

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
#4317 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATVow_4KiL4qB5R7N3GsMKNltlaKUqiks5q6ilfgaJpZM4KUctC
.

[pascalgrimaud]

How can we advance on it ?
I already have yarn working on Travis build and on maven-frontend-plugin. I didn't work on gradle yet.

I see 3 solutions:

1. support both (npm and yarn) by adding a new question, and save yarn: false/true in .yo-rc.json file.
2. migrate to yarn completely (less work, but risky as it is still in 0.X.X)
3. wait :-)

[jdubois]

If that's not a lot of work, here's my proposal:

• We put Yarn by default, and tell everyone to use it
• We watch the stats

-> if the stats show we have less than 5% of people using NPM, we can ditch it without any problem. That's what I did for Java 7, and that was very successful (= no complaint at all!)

[pascalgrimaud]

• should I add a new question for yarn / npm ?
• or should I add a new flag --npm for people who want to stay with npm

[jdubois]

Oh good question!

• A question adds more visibility
• A flag is only for advanced users

So if our final goal is to push Yarn, I would make it only a flag.

[gmarziou]

For developers, are we supposed to use yarn link rather than npm link?

[wmarques]

@gmarziou yep

[PierreBesson]

Yes and we should update the CONTRIBUTING.md file to document it.

[pascalgrimaud]

@gmarziou :

• in your local forked project (generator-jhipster): yarn link
• when you want to generate a new project:
  • mkdir tmp && cd tmp
  • yarn link generator-jhipster
  • yo jhipster

[gmarziou]

OK thanks

[jdubois]

Can we close this? It's fully working for me!

[pascalgrimaud]

There are few things to do like documentation, but we can follow this ticket #4703 for this
So yes!

[cbornet]

Is it time to merge jhipster/jhipster-devbox#72 ?

[jdubois]

@cbornet only once JHipster 4 is released, at the moment we need NPM

[jdubois]

OK thanks @pascalgrimaud let's close this!

[gmarziou]

Shouldn't we add yarn.lock file to the generator repo?

[jdubois]

For me it's the "good practice", so yes. But we haven't used this for long enough to be sure :-)

[cbornet]

Are we sure we can do it for all combination of options ?

[jdubois]

@cbornet I guess we can commit the one from the generator. Then, for each generated project, that's another story - yes we should commit it, but that's going to be a nightmare to generate... I would just let people commit it themselves after generation.

[deepu105]

Yes we should just let people add it to VCS. i dont think there is any value in generating it Thanks & Regards, Deepu

…

On Thu, Dec 22, 2016 at 9:57 PM, Julien Dubois ***@***.***> wrote: @cbornet <https://github.com/cbornet> I guess we can commit the one from the generator. Then, for each generated project, that's another story - yes we should commit it, but that's going to be a nightmare to generate... I would just let people commit it themselves after generation. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4317 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABDlF5bTBmiNhr6Eu8O_L0WUTItajdPEks5rKuQtgaJpZM4KUctC> .

[allahbaksh]

So what is the dev flow is mvn spring-boot:run and yarn?

[jdubois]

@allahbaksh this is for JHipster 4, it's not released yet, and not documented yet

[allahbaksh]

By the way if we install yarn through npm on MAC some time it has issues. Spent almost 3 hours on figuring out this.

[gmarziou]

On Windows also there are issues, I could not make it work with nodist, I had to switch back to simpler standard installation of Node

[allahbaksh]

webpack is throwing error var shouldExtract = !!(options.allChunks || chunk.isInitial());
TypeError: chunk.isInitial is not a function. Any workaround for this.

Got it worked by yarn add extract-text-webpack-plugin. Now have to resolve other issues.