-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create auto labeler workflow for PRs [skip ci] #11312
Conversation
triage: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: mshima/labeler@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it your own action ? did you fork the project ? in this case, we can host it under jhipster organization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
The changes I’ve made is actions/labeler#49.
I don’t have permission to create new repositories.
Can you clone my?
If you clone upstream, then you have to copy the dependencies too.
on: | ||
schedule: | ||
# * is a special character in YAML so you have to quote this string | ||
- cron: '*/5 * * * *' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid of this, as it will be launched all the time and we won't find in Actions list the other builds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can reduce this to one an hour.
I’ve set to 5 min to test.
I am a bit doubtful on this change. Maybe we need to think of a different approach 🤔
Just my two cents 😄 |
I think labeling removing is minor. Another approach is to create jhipster teams and use code owner. |
Following #11283
This PR creates a workflow for auto labeling PRs based on the files changes.
It uses scheduled runs and tags PRs that aren't tagged yet.
Why don't use on pull_request? actions/labeler#12
Once this bug is resolved, we should switch to on pull_request.
Please make sure the below checklist is followed for Pull Requests.
All continuous integration tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed