Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions supports colors but due to a bug its disabled at current chalk release. #11834

Merged
merged 1 commit into from
May 21, 2020

Conversation

mshima
Copy link
Member

@mshima mshima commented May 21, 2020

This PR force chalk to enable colors.

@pascalgrimaud pascalgrimaud merged commit 88a6782 into jhipster:master May 21, 2020
@pascalgrimaud
Copy link
Member

@mshima : nice ! maybe we should do the same for the sub gen ci/cd ?

@mshima
Copy link
Member Author

mshima commented May 21, 2020

@pascalgrimaud forcing colors with chalk can cause problems for some use cases.
Generator workflow didn't pass because it compared a console output with chalk with a normal string.

@mshima mshima deleted the colors branch May 21, 2020 16:45
@pascalgrimaud pascalgrimaud added this to the 6.9.1 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants