Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id fluent setter to Entity. #12029

Merged
merged 1 commit into from
Jul 4, 2020
Merged

Conversation

mshima
Copy link
Member

@mshima mshima commented Jul 3, 2020

Currently we are not generating fluent id setter.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@pascalgrimaud pascalgrimaud merged commit dfde98a into jhipster:master Jul 4, 2020
@mshima mshima deleted the fluent_id branch July 4, 2020 16:09
@murdos
Copy link
Contributor

murdos commented Jul 4, 2020

I think the reason was that we're not supposed to manually set the id of an entity.

@mshima
Copy link
Member Author

mshima commented Jul 4, 2020

I think the reason was that we're not supposed to manually set the id of an entity.

I think so, but for specific use cases this can be useful.
Eg: foo.bar(new bar().id(barId));.

For completeness I think it is better to include.

@pascalgrimaud pascalgrimaud added this to the 7.0.0 milestone Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants