Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable audit at npm install #15041

Merged
merged 2 commits into from
May 20, 2021
Merged

Disable audit at npm install #15041

merged 2 commits into from
May 20, 2021

Conversation

mshima
Copy link
Member

@mshima mshima commented May 19, 2021

Workaround npm/cli#2715.

Closes #14934.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima force-pushed the skip_ci-skip_audit branch from 5c5bcf6 to ae54ec9 Compare May 19, 2021 15:52
@mshima mshima force-pushed the skip_ci-skip_audit branch from ae54ec9 to 6713bf8 Compare May 19, 2021 16:14
@mshima mshima force-pushed the skip_ci-skip_audit branch from 6713bf8 to a0e8d41 Compare May 19, 2021 19:27
<%_ if (!skipClient) { _%>

if (project.hasProperty("nodeInstall")) {
// Workaround node grade plugin not working on apple silicon https://github.com/node-gradle/gradle-node-plugin/issues/154
OperatingSystem os = org.gradle.nativeplatform.platform.internal.DefaultNativePlatform.getCurrentOperatingSystem();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mshima
Copy link
Member Author

mshima commented May 20, 2021

The errors are not related to this PR.
Seems some Angular dependency broke npm 7 resolution pretty bad.
No clue how to find it.
Retriggered a succeed build (https://github.com/jhipster/generator-jhipster/runs/2625012481) and it failed.

Merging since it fixes react and vue.

@mshima mshima merged commit 02446ef into jhipster:main May 20, 2021
@mshima
Copy link
Member Author

mshima commented May 20, 2021

A workaround for now is to add .npmrc with legacy-peer-deps.

@pascalgrimaud pascalgrimaud added this to the 7.1.0 milestone May 28, 2021
@mshima mshima deleted the skip_ci-skip_audit branch July 3, 2021 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failing because npm audit need fix
4 participants