Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hazelcast 2nd level cache + Cucumber test failing #2553 #2589

Merged
merged 3 commits into from
Jan 10, 2016

Conversation

lordlothar99
Copy link
Contributor

#2553 splitted cucumber / not cucumber tests execution

…itted cucumber / not cucumber tests execution
@deepu105
Copy link
Member

deepu105 commented Jan 9, 2016

Is it required in gradle? cc @atomfrede

@atomfrede
Copy link
Member

I think there was already a fix for gradle. It was only failing with maven.
Am 09.01.2016 2:15 vorm. schrieb "Deepu k Sasidharan" <
notifications@github.com>:

Is it required in gradle? cc @atomfrede https://github.com/atomfrede


Reply to this email directly or view it on GitHub
#2589 (comment)
.

@pascalgrimaud
Copy link
Member

Yes, Gradle was fixed here #2275

<exclude>**/*Cucumber*.java</exclude>
</excludes>
</configuration>
</execution>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works for all current config, but shouldn't we add this new code only for cucumber ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should only be added for Cucumber

@jdubois
Copy link
Member

jdubois commented Jan 9, 2016

Please have a look at the comment: you need to make a switch so that this is only generated for Cucumber

And then I'll merge this, of course!

@lordlothar99
Copy link
Contributor Author

Sure! I'll do that today

@jdubois
Copy link
Member

jdubois commented Jan 10, 2016

Cool, let's do this :-)

jdubois added a commit that referenced this pull request Jan 10, 2016
Hazelcast 2nd level cache + Cucumber test failing #2553
@jdubois jdubois merged commit bedfcc5 into jhipster:master Jan 10, 2016
@jdubois jdubois modified the milestone: 2.27.0 Jan 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants