Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application field not sent to prometheus #27065

Merged

Conversation

vmartowicz
Copy link
Contributor

add the yml property management.metrics.tags.application with value ${spring.application.name} Fix #27047


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

add the yml property management.metrics.tags.application with value ${spring.application.name}
Fix jhipster#27047
@vmartowicz
Copy link
Contributor Author

I do not understand the errors

  • You have duplicate properties in entity BankAccount: operations
  • closing-issues

And I don't know where to add tests about the fix
Do I need something to do?

@mshima
Copy link
Member

mshima commented Aug 25, 2024

The error is related to :

relationship OneToMany {
  BankAccount{operation} to Operation
}
relationship ManyToOne {
  Operation{bankAccount(name)} to BankAccount{operation}
}

may be a jdl export bug.

@vmartowicz
Copy link
Contributor Author

Hi @mshima

Thanks for your response.
So What do I need to do for validating the fix? Wait for the fix about jdl export?
The fix does not concern the error

And what about the second error?

@mshima mshima merged commit 538dc04 into jhipster:main Aug 26, 2024
50 of 52 checks passed
@mshima
Copy link
Member

mshima commented Aug 26, 2024

@vmartowicz can you share BankAccount and Operation json files from .jhipster folder?

@vmartowicz
Copy link
Contributor Author

@mshima

Sure, file are from /test-integration/samples/.jhipster path

BankAccount.json
Operation.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics "application" field not sent to prometheus
3 participants