Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update spring-boot-dependencies bom to v3.3.5 #27677

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

update spring-boot-dependencies bom to v3.3.5

@github-actions github-actions bot added the theme: dependencies Pull requests that update a dependency file label Oct 24, 2024
@mshima mshima marked this pull request as draft October 24, 2024 13:56
@mshima mshima closed this Oct 24, 2024
@mshima mshima reopened this Oct 24, 2024
@DanielFran
Copy link
Member

📊 SonarQube Analysis for ng-default

Metric Value
New Vulnerabilities 0
New Bugs 0
New Code smells 0
Coverage on New Code N/A%
Duplication on New Code N/A%

Copy link
Member

@DanielFran DanielFran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add back couchmove
See #27563

@@ -46,9 +47,8 @@
<commons-pool.version>1.6</commons-pool.version>
<commons-pool2.version>2.12.0</commons-pool2.version>
<couchbase-client.version>3.6.3</couchbase-client.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<couchbase-client.version>3.6.3</couchbase-client.version>
<couchbase-client.version>3.6.3</couchbase-client.version>
<couchmove.version>3.4.1</couchmove.version>

@@ -427,11 +427,6 @@
<artifactId>java-client</artifactId>
<version>${couchbase-client.version}</version>
</dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</dependency>
</dependency>
<dependency>
<groupId>com.github.differentway</groupId>
<artifactId>couchmove</artifactId>
<version>${couchmove.version}</version>
</dependency>

@mshima
Copy link
Member

mshima commented Oct 24, 2024

Add back couchmove See #27563

I didn’t realized it was added to the spring-boot pom.
It should be added to dependabot instead.

@mraible
Copy link
Contributor

mraible commented Oct 24, 2024

FYI... from https://twitter.com/sdeleuze/status/1849489721556418920

If you are using r2dbc, I strongly recommend upgrading to Spring Boot 3.3.5 which contains an amazing optimization crafted by mp911de and chemicL which provides a huge performance boost (higher thoughput, lower latency) under high concurrency.

I removed @ from the tweet above so no one is tagged.

@mshima
Copy link
Member

mshima commented Oct 24, 2024

I think CI is failing due to spring-cloud/spring-cloud-gateway#3568.
There is not exception in logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: dependencies Pull requests that update a dependency file theme: java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants