Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use single expression functions #153

Closed
1 task done
pvliss opened this issue Jun 21, 2019 · 5 comments · Fixed by #165
Closed
1 task done

Use single expression functions #153

pvliss opened this issue Jun 21, 2019 · 5 comments · Fixed by #165
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@pvliss
Copy link
Contributor

pvliss commented Jun 21, 2019

Overview of the issue

Use single expression functions where possible

Motivation for or Use Case

Simplify generated code

  • Checking this box is mandatory (this is just to show you read everything)
@pvliss
Copy link
Contributor Author

pvliss commented Jun 21, 2019

@sendilkumarn This should also be fairly simple. Can you add some labels here as well as I am not allowed to add them?

@sendilkumarn
Copy link
Member

I love this and it makes the code concise 👍

@sendilkumarn sendilkumarn added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 21, 2019
@sendilkumarn
Copy link
Member

@pvliss done that just now

@pvliss
Copy link
Contributor Author

pvliss commented Jun 21, 2019

@sendilkumarn I agree and thanks

@pvliss
Copy link
Contributor Author

pvliss commented Jun 27, 2019

Going to start working on this one

pvliss added a commit to pvliss/jhipster-kotlin that referenced this issue Jun 28, 2019
@pvliss
Use single expression functions
4b2ef99 
Fix jhipster#153
@pvliss pvliss mentioned this issue Jun 28, 2019
Merged
pvliss added a commit to pvliss/jhipster-kotlin that referenced this issue Jun 28, 2019
@pvliss
Use single expression functions
3267468 
Fix jhipster#153
pvliss added a commit to pvliss/jhipster-kotlin that referenced this issue Jun 28, 2019
@pvliss
Use single expression functions
ba1976d 
Fix jhipster#153
pvliss added a commit to pvliss/jhipster-kotlin that referenced this issue Jun 28, 2019
@pvliss
Use single expression functions
5827290 
Fix jhipster#153
pvliss added a commit to pvliss/jhipster-kotlin that referenced this issue Jun 28, 2019
@pvliss
Use single expression functions
3b0bb41 
Fix jhipster#153
pvliss added a commit to pvliss/jhipster-kotlin that referenced this issue Jun 28, 2019
@pvliss
Use single expression functions
f88742e 
Fix jhipster#153
pvliss added a commit to pvliss/jhipster-kotlin that referenced this issue Jun 28, 2019
@pvliss
Use single expression functions
4abc2b7 
Fix jhipster#153
pvliss added a commit to pvliss/jhipster-kotlin that referenced this issue Jun 28, 2019
@pvliss
Use single expression functions
81ff530 
Fix jhipster#153
pvliss added a commit to pvliss/jhipster-kotlin that referenced this issue Jul 4, 2019
@pvliss
Use single expression functions - Review fixes
5161f78 
Fix jhipster#153
sendilkumarn pushed a commit that referenced this issue Jul 4, 2019
@pvliss @sendilkumarn
Use single expression functions (#165)
193ae8f 
* Use single expression functions

Fix #153

* Fix ktlint format for maven

* Formatting

* Use single expression functions

Fix #153

* Use single expression functions - Review fixes

Fix #153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use single expression functions pvliss/jhipster-kotlin
2 participants
@pvliss @sendilkumarn