Remove side affect of mock DateTimeProvider #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
1 task
…meProvider. To avoid side affect we need to use @MockBean
Romancha
force-pushed
the
affect-mock-datetimeprovider
branch
from
a8e2e99 to
9675849
Compare
sendilkumarn
approved these changes
Jul 5, 2020
There was a problem hiding this comment.
Congrats on your first contribution @Romancha 🎉
Can you also port this to the main generator? I think that is also using @Mock.
Thank! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using mock for dateTimeProvider may affect users test that use dateTimeProvider. To avoid side affect we need to use @MockBean
Link to issue