Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint warnings #257

Merged
merged 6 commits into from
Sep 9, 2020
Merged

Fix lint warnings #257

merged 6 commits into from
Sep 9, 2020

Conversation

isaul32
Copy link
Contributor

@isaul32 isaul32 commented Sep 5, 2020

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@isaul32
Copy link
Contributor Author

isaul32 commented Sep 5, 2020

I think checks should fail if get any lint warning or error.

sendilkumarn
sendilkumarn requested changes Sep 7, 2020
View reviewed changes
Copy link
Member

@sendilkumarn sendilkumarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @isaul32 for the PR.

generators/server/templates/src/main/kotlin/package/security/SecurityUtils.kt.ejs Outdated Show resolved Hide resolved
@isaul32 isaul32 marked this pull request as draft September 8, 2020 06:43
@isaul32 isaul32 marked this pull request as ready for review September 8, 2020 12:38
@isaul32 isaul32 requested a review from sendilkumarn September 8, 2020 12:38
sendilkumarn
sendilkumarn approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@sendilkumarn sendilkumarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks. Thanks for fixing other indentation issues too.

@sendilkumarn
Copy link
Member

Congrats on your first contribution 🎉

@sendilkumarn sendilkumarn merged commit 57a449b into jhipster:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sendilkumarn sendilkumarn sendilkumarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isaul32 @CLAassistant @sendilkumarn