Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove val usage in TokenProvider #329

Closed

Conversation

emilpaw
Copy link
Contributor

@emilpaw emilpaw commented Mar 12, 2022

A part towards #306

@sendilkumarn
Copy link
Member

sendilkumarn commented Mar 13, 2022

Thanks @emilpaw for the contribution 🎉

(Congrats on your first contribution)

This looks good! I started the CI will merge it when it finishes.

@sendilkumarn
Copy link
Member

@emilpaw can you please take a look at the build? there are few failures..

@emilpaw
Copy link
Contributor Author

emilpaw commented Apr 1, 2022

@sendilkumarn Many of the failing tests have definitely nothing to do with my changes. e.g. all the React tests fail because of this issue: #330
The ngx-gradle-fr test also fails because of some frontend related issue: https://github.com/jhipster/jhipster-kotlin/runs/5526701353?check_suite_focus=true

I'd like to wait until the issues are resolved before I continue to work on this PR.

@emilpaw emilpaw force-pushed the remove-val-from-token-provider branch from ac344ae to e156d97 Compare April 18, 2022 12:37
@sendilkumarn
Copy link
Member

Closing this in favor of #335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants