Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harmonize the css with the current jhipster-website design #10702

Conversation

renanfranca
Copy link
Contributor

@renanfranca renanfranca commented Aug 29, 2024

See the description for the complete roadmap

A demo showing the improvement:

jhlite-harmonized.mp4

The TO-DO list:

  • Updated the modules-patch filter input light theme style in _modules-patch.scss.
  • Removed duplicated variables in _modules-patch.scss.
  • Replaced $jhlite-color-brand-800 with $jhlite-color-brand-700 as $jhlite-global-primary-color.
  • Improved landscape-preset-configuration style by setting the top-left border-radius to zero.
  • Refactored landscape-preset-configuration to use local variables instead of those from another organism.
  • Improved the landscape preset configuration example in landscape-preset-configuration.mixin.pug.
  • Added a select field example in field.code.pug.
  • Refactored select style to use global constants in _select.scss.
  • Created an SCSS variable for semi-bold font weight.
  • Updated input text light theme style in quark/_quark.scss.
  • Updated select light theme style in _select.scss.
  • Updated button light theme style in _button.scss.
  • Added Inter font family SemiBold in inter.scss.
  • Replaced Roboto font-family with Inter in the project.

@renanfranca renanfranca self-assigned this Aug 29, 2024
@renanfranca renanfranca mentioned this pull request Aug 29, 2024
5 tasks
@renanfranca renanfranca changed the title harmonize the css with the current jhipster-website design harmonize the css with the current jhipster-website design Aug 29, 2024
@pascalgrimaud
Copy link
Member

pascalgrimaud commented Aug 29, 2024

I don't understand the link in the description as it's related to svelte :-D

@renanfranca
Copy link
Contributor Author

I don't understand the link in the description as it's related to svelte :-D

HAhaha 🤣😅! I updated it now. I don't know how I did it 😅🤷‍♂️

@renanfranca
Copy link
Contributor Author

In my opinion, these changes make the screen more comfortable, relaxed, and less dense. I created the video because the changes are subtle, but together they bring a sense of joy. Now I understand the true meaning of 'harmonize' in CSS, especially when based on an existing design.

@pascalgrimaud pascalgrimaud merged commit f858105 into jhipster:main Aug 30, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants