Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update apache/kafka-native Docker tag to v3.9.0 #11323

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Nov 8, 2024

Fix #11313

@pascalgrimaud @murdos I opend an issue testcontainers/testcontainers-java#9506 on tescontainers.
I use temporary fix proposed on the ticket.

@murdos
Copy link
Contributor

murdos commented Nov 8, 2024

Thanks for raising the issue on testcontainers side.

I'd rather wait for the fix/official support from testcontainers. I don't think we're in a hurry to make the upgrade, but that's just my opinion.

@qmonmert
Copy link
Contributor Author

qmonmert commented Nov 8, 2024

@murdos ok

@pascalgrimaud merge or wait? 🙂

@pascalgrimaud
Copy link
Member

In fact, I'm not sure it's an issue.
Maybe the proposed fix is what we should do, as our generated kafka.yml already have this property:

image

@qmonmert
Copy link
Contributor Author

@pascalgrimaud I believe that kafkaContainer = new KafkaContainer(DockerImageName.parse("apache/kafka-native:3.9.0")).withNetwork(null); not used kafka.yml to start, so updating this file won't change behavior

@pascalgrimaud
Copy link
Member

Yes I know, I wanted to say your suggestion would be consistent with the generated kafka.yml file

@qmonmert
Copy link
Contributor Author

@pascalgrimaud
Copy link
Member

I'm merging this, so the upgrade to the v3.9.0 Docker image can be done, until there is a v3.9.1 with an eventual fix

@pascalgrimaud pascalgrimaud merged commit 2ab3d86 into jhipster:main Nov 11, 2024
36 checks passed
@qmonmert
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants