Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tikui styles broken by inter.css #11443

Conversation

renanfranca
Copy link
Contributor

@renanfranca renanfranca commented Nov 27, 2024

After some research, I found the reason why the inter font-family changed the sun (☀️) emoji color to grey only on Chrome and not on Firefox.

Firefox:
image

Chrome:
image

According to the documentation, the Inter font has a specific behavior with certain emojis due to a specific glyph (U+20E3) that interferes with the rendering of special characters in Chrome[1]. This issue occurs because Chrome has difficulty resolving characters when the Inter font is present, causing some specific emojis not to render correctly[1].

The problem doesn't affect all emojis, only specific characters, as it depends on how Chrome discovers and resolves these special characters when it finds the Inter font in its font stack[1]. When Inter is present, Chrome cannot properly fall back to the system's emoji font in some specific cases[1].

Unfortunately, I can't explain why the moon emoji (🌙) didn't turn grey and only the sun emoji (☀️). However, the technical behavior described explains why some emojis are affected while others continue to work normally.

Citations:
[1] tailwindlabs/tailwindcss#2499
[2] https://rsms.me/inter/
[3] rsms/inter#371
[4] https://forum.obsidian.md/t/the-sun-emoji-is-displayed-as-a-monochrome-glyph/47751

Use the sun and moon here:

image

@renanfranca renanfranca added the area: bug 🐛 Something isn't working label Nov 27, 2024
@renanfranca renanfranca self-assigned this Nov 27, 2024
@renanfranca renanfranca requested a review from qmonmert November 27, 2024 15:23
Copy link
Contributor

@qmonmert qmonmert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, but strangely I don't reproduce on the main branch (on Chrome, maybe new version of Chrome fixes that)

@renanfranca
Copy link
Contributor Author

ok, but strangely I don't reproduce on the main branch (on Chrome, maybe new version of Chrome fixes that)

I used an old version of Chrome in my wsl2 Ubuntu.

@renanfranca renanfranca merged commit 7446b20 into jhipster:main Nov 27, 2024
37 checks passed
@renanfranca
Copy link
Contributor Author

ok, but strangely I don't reproduce on the main branch (on Chrome, maybe new version of Chrome fixes that)

@qmonmert : I tested in Vivaldi browser which is based in chromium like google chrome and the sun is grey:

image

And the moon is yellow:
image

@qmonmert
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tikui: inter.css brokes style
2 participants