-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modules landscape #3022
Modules landscape #3022
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3022 +/- ##
============================================
Coverage 100.00% 100.00%
- Complexity 1979 2073 +94
============================================
Files 467 506 +39
Lines 7975 8448 +473
Branches 153 161 +8
============================================
+ Hits 7975 8448 +473
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
63408ee
to
63842c1
Compare
An idea may be to merge all dependencies from a feature to something so we can have less lines In the current landscape this removes 17 connections, it require some effort but it's probably worth it |
Back to draft: just saw that resizes when scrolled send the lines very far, need to fix that :) -> Fixed |
63842c1
to
2d01134
Compare
14611b9
to
2bbc84b
Compare
2bbc84b
to
57d3506
Compare
Overnight though:
But all this will be in dedicated PR since this one is already huge and we first need to reorganize some modules |
Good idea to split PRs 😄 I've just read this PR, seems good. Nice work!! |
|
Not for all cases (because sometimes all modules in the same feature don't share the same dependencies) but this is this comment:
|
Close #2996
Related to #1666
This is a first version, still not really usable as is, here is the beginning of the tree:
This first part is OK but then comes a problem when we have modules depending on multiple levels, here is one of the worst part (bottom of levels 4 to 6):
Easy problems to tackle next:
Harder problems: