Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bootstrap #3377

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Remove bootstrap #3377

merged 1 commit into from
Sep 2, 2022

Conversation

Gnuk
Copy link
Collaborator

@Gnuk Gnuk commented Aug 31, 2022

@DamnClin
Copy link
Collaborator

Some bootrstrap css classes in Toast.vue

@Gnuk
Copy link
Collaborator Author

Gnuk commented Aug 31, 2022

Some bootrstrap css classes in Toast.vue

I've already noticed this, so it's good for me but thank you for the reminder. I'lll start it just after ;)

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #3377 (2e93fbb) into main (a7ede88) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main     #3377   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2004      2004           
===========================================
  Files            531       531           
  Lines           8652      8653    +1     
  Branches         179       179           
===========================================
+ Hits            8652      8653    +1     
Impacted Files Coverage Δ
...webapp/app/common/primary/toast/Toast.component.ts 100.00% <100.00%> (ø)
...pp/module/primary/landscape/Landscape.component.ts 100.00% <100.00%> (ø)
...rimary/project-actions/ProjectActions.component.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@DamnClin
Copy link
Collaborator

DamnClin commented Sep 1, 2022

Do you plan to take care of #3372 here?

@Gnuk
Copy link
Collaborator Author

Gnuk commented Sep 1, 2022

Do you plan to take care of #3372 here?

I can but where do you want to see the area?

@DamnClin
Copy link
Collaborator

DamnClin commented Sep 1, 2022

I can but where do you want to see the area?

No idea, this needs some trys...

@Gnuk Gnuk force-pushed the remove-bootstrap branch 3 times, most recently from c8ab897 to 9efd68a Compare September 2, 2022 13:59
@Gnuk
Copy link
Collaborator Author

Gnuk commented Sep 2, 2022

Currently i've added the Toast is a simple version. But cause we're not using Bootstrap anymore I have not implemented the timeout system yet.

@DamnClin : Is it possible to code it in another PR?

(currently, to close the Toast, you have to click on close button)

@DamnClin
Copy link
Collaborator

DamnClin commented Sep 2, 2022

The described behavior is ok me but I haven't read the PR nor tried it so can't validate for now :D. @pascalgrimaud can you review that?

@Gnuk Gnuk marked this pull request as ready for review September 2, 2022 14:46
@pascalgrimaud pascalgrimaud merged commit 07e4d35 into jhipster:main Sep 2, 2022
@DamnClin DamnClin mentioned this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove bootstrap
3 participants