Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chip atom #4089

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Add chip atom #4089

merged 1 commit into from
Nov 1, 2022

Conversation

nassimerrahoui
Copy link
Contributor

@nassimerrahoui nassimerrahoui commented Oct 24, 2022 •
edited
Loading

This is PR add a Tikui component called Chip to modelize one module in the landscape + integration into the webapp. This is related to CSS migration to Tikui.

I'm working with @Gnuk to coordonate CSS migration to Tikui.

Here is what it looks like with the component :

Capture d’écran 2022-10-31 à 10 22 13

Capture d’écran 2022-10-31 à 09 55 11

Capture d’écran 2022-10-31 à 09 48 15

@codecov
Copy link

codecov bot commented Oct 24, 2022 •
edited
Loading

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (ebf3785) compared to base (0be879d).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@             Coverage Diff             @@
##                main     #4089   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2130      2130           
===========================================
  Files            572       572           
  Lines           9281      9281           
  Branches         176       176           
===========================================
  Hits            9281      9281

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nassimerrahoui nassimerrahoui marked this pull request as ready for review October 24, 2022 16:51
@Gnuk Gnuk mentioned this pull request Oct 25, 2022
Merged
@nassimerrahoui nassimerrahoui marked this pull request as draft October 25, 2022 12:16
@nassimerrahoui nassimerrahoui force-pushed the tikui-migration/atom/chip branch 5 times, most recently from 838b9da to 603bf05 Compare October 27, 2022 07:31
@nassimerrahoui nassimerrahoui marked this pull request as ready for review October 27, 2022 07:35
@nassimerrahoui
Copy link
Contributor Author

@Gnuk I think it's ready for a first review

@nassimerrahoui nassimerrahoui force-pushed the tikui-migration/atom/chip branch 2 times, most recently from f2059fc to a9f5307 Compare October 27, 2022 07:53
@Gnuk
Copy link
Collaborator

Gnuk commented Oct 31, 2022

I think you need to add an example of the applied chip inside the pattern library

@nassimerrahoui nassimerrahoui force-pushed the tikui-migration/atom/chip branch 2 times, most recently from 32160b5 to 9891142 Compare October 31, 2022 08:50
@nassimerrahoui
Copy link
Contributor Author

I think you need to add an example of the applied chip inside the pattern library

Done 👍

@nassimerrahoui
Copy link
Contributor Author

@Gnuk I also updated the screenshots

Gnuk
Gnuk suggested changes Oct 31, 2022
View reviewed changes
src/main/style/token/_colors.scss Outdated Show resolved Hide resolved
src/main/webapp/app/module/primary/landscape/Landscape.vue Outdated Show resolved Hide resolved
@Gnuk
Copy link
Collaborator

Gnuk commented Oct 31, 2022

@Gnuk I also updated the screenshots

Sorry, I just forgot to apply the review, T-T

@nassimerrahoui
Copy link
Contributor Author

@Gnuk I also updated the screenshots

Sorry, I just forgot to apply the review, T-T

@Gnuk it's ok 👌

@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels Oct 31, 2022
@pascalgrimaud
Copy link
Member

Adding a bounty on this
Thanks for the work @nassimerrahoui !

Gnuk
Gnuk previously approved these changes Oct 31, 2022
View reviewed changes
@nassimerrahoui
Copy link
Contributor Author

Adding a bounty on this Thanks for the work @nassimerrahoui !

@pascalgrimaud @Gnuk Nice, thank you :D

@pascalgrimaud pascalgrimaud merged commit 2c7991e into jhipster:main Nov 1, 2022
@nassimerrahoui
Copy link
Contributor Author

@pascalgrimaud Bounty claimed https://opencollective.com/generator-jhipster/expenses/105073 :)

@pascalgrimaud
Copy link
Member

@nassimerrahoui : approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gnuk Gnuk Gnuk approved these changes

Assignees
No one assigned
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ generator: internal $200 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nassimerrahoui @Gnuk @pascalgrimaud