Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Mustache.java for template rendering #9624

Merged
merged 9 commits into from
Apr 26, 2024

Conversation

murdos
Copy link
Contributor

@murdos murdos commented Apr 23, 2024

This brings possibility to do more advanced templating, rather than just arguments replacement.

Use this enhanced templating to simplify generated SpringLiquibaseUtilTest

…eUtilTest

Rather than generating code that handles all configuration format, just generates the required code for the chosen configuration format.
@murdos
Copy link
Contributor Author

murdos commented Apr 23, 2024

@swarajsaaj: If you want to take a look, since you work on #9332 inspired me for these changes. I don't know why, but I can't add you to reviewers :/

@swarajsaaj
Copy link
Contributor

@swarajsaaj: If you want to take a look, since you work on #9332 inspired me for these changes. I don't know why, but I can't add you to reviewers :/

Awesome work @murdos 👍 , SpringLiquibaseUtilTest looks much better now, the way it should be.

@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $200 https://www.jhipster.tech/bug-bounties/ labels Apr 24, 2024
@pascalgrimaud
Copy link
Member

Adding a bounty as it seems advanced work

@murdos murdos merged commit 9e38928 into jhipster:main Apr 26, 2024
35 checks passed
@murdos murdos deleted the chore/add-mustache branch April 26, 2024 19:07
@murdos
Copy link
Contributor Author

murdos commented Jun 23, 2024

@pascalgrimaud
Copy link
Member

@murdos : approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ generator: internal $200 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants