-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enforce blank line after body declaration #398
Conversation
ping @Shaolans @clementdessoude |
It should be good to go but as I explained with this PR, when you now define an anonymous class it will enforce a blank line and I was wondering if we should keep it that way. |
ok, you're right @Shaolans |
@Shaolans Is there any update on this PR, please. I would like to adopt prettier-java in my new project but because of this issue, I would not be able. |
Hi, |
d7b7e8b
to
2e35efe
Compare
It should be good to go. |
If @clementdessoude is not available can someone else merge this PR, please! Maybe @pascalgrimaud or @deepu105. |
I'll contact Clement today |
Thanks, @pascalgrimaud for merging this PR. I guess the team is waiting for other PRs (#384) to get merged, after that the new release will come out. Hoping for the new release coming out soon. |
@sanjayrawat1 : I don't forget you. I didn't manage to contact @clementdessoude about release process. |
Just have some news about Clément. He told me he'll try to find time for reviewing the other PR and will do a new release during this week-end. |
@pascalgrimaud Yeah, it's fine. Thanks a lot! |
@pascalgrimaud can we have a release, please? |
@sanjayrawat1 : I'll try |
@sanjayrawat1 : just release v0.8.3 -> https://github.com/jhipster/prettier-java/releases/tag/v0.8.3 |
@pascalgrimaud Yeah, it's working as expected. Thanks :) |
Thank you for taking care of the release @pascalgrimaud ! |
What changed with this PR:
Fix #271
Example
However it should be noted that we can have this case:
Since inside the class this is also a classBodyDeclaration node.
I think we can probably make an exception on class body for anonymous class but I don't know if we should.
Relative issues or prs: