chore(deps): update dependency go to v1.25.4

[red-hat-konflux-kflux-prd-rh03]

This PR contains the following updates:

Package	Type	Update	Change
go (source)	toolchain	minor	1.24.4 -> 1.25.4

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

To execute skipped test pipelines write comment /ok-to-test.

---

Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

[claude]

PR Review: Go Toolchain Update to 1.25.3

Summary

This PR updates the Go toolchain from 1.24.4 to 1.25.3. This is an automated dependency update from Renovate/MintMaker.

Analysis

Code Quality ✅

• The change is minimal and focused (1 line change in go.mod)
• No code logic changes, only toolchain version update
• The minimum Go version requirement remains go 1.24.0, which is appropriate

Compatibility Considerations ⚠️

CI/CD Workflow Mismatch: The GitHub Actions workflows currently specify Go 1.24:

# .github/workflows/test.yml lines 21, 52, 72, 95
- name: Set up Go
  uses: actions/setup-go@v5
  with:
    go-version: '1.24'

Recommendation: Update the CI workflows to use go-version: '1.25' to match the toolchain version. This ensures CI and production environments use consistent tooling.

Container Build Image: The Containerfile uses a hardcoded Go version:

FROM registry.access.redhat.com/ubi9/go-toolset:1.24.6-1760420453 AS builder

Recommendation: Update to a UBI9 go-toolset image with Go 1.25.x when available from Red Hat, or consider using a base image tag that auto-updates minor versions.

Potential Issues 🔍

1. Version Skew: The toolchain directive in go.mod specifies a newer version than what CI and the container build use. While Go's backward compatibility means this will work, it could lead to subtle differences in behavior between development and CI/production environments.

2. Dependency Compatibility: All dependencies listed in go.mod should be compatible with Go 1.25, as they were working with 1.24. However, running the full test suite is recommended to verify.

Testing Requirements 📋

Before merging, verify:

• All unit tests pass (make test-unit)
• Integration tests pass (make test-integration)
• Build succeeds (make build)
• Container build succeeds with the current UBI9 go-toolset image

Security ✅

No security concerns with this update. Go 1.25.3 includes security fixes from the Go team.

Performance ✅

No performance concerns. Go 1.25 generally includes performance improvements over 1.24.

Recommendations

Priority 1 - High:

1. Update .github/workflows/test.yml to use go-version: '1.25' across all jobs

Priority 2 - Medium:
2. Update Containerfile to use a Go 1.25.x base image when available from Red Hat
3. Run the full test suite to ensure compatibility

Priority 3 - Low:
3. Consider adding a comment in CLAUDE.md dependencies section noting the Go version to keep documentation current

Verdict

✅ Approve with recommendations - The core change is safe and follows standard dependency update practices. However, the CI/CD and container build configurations should be updated to match the new toolchain version to avoid environment inconsistencies.

---

🤖 Review generated by Claude Code

[claude]

Pull Request Review: Go 1.25.4 Toolchain Update

Overview

This PR updates the Go toolchain from version 1.24.4 to 1.25.4. This is an automated dependency update from MintMaker/Renovate.

---

Code Quality & Changes ✅

APPROVED - The change is minimal and appropriate:

• Single line change in go.mod updating the toolchain directive
• Maintains go 1.24.0 as the minimum required version
• Only updates the toolchain version used for building

---

Compatibility Analysis ⚠️

Issues Identified:

1. CI Workflow Mismatch (High Priority)

   • Location: .github/workflows/test.yml
   • Issue: All CI jobs are configured to use Go 1.24:

     - name: Set up Go
       uses: actions/setup-go@v5
       with:
         go-version: '1.24'  # ← Needs updating

   • Impact: CI will build and test with Go 1.24, but the toolchain directive specifies 1.25.4, creating a mismatch between CI and local builds
   • Recommendation: Update all go-version values in .github/workflows/test.yml to '1.25' or '1.25.4'

2. Container Image Mismatch (High Priority)

   • Location: Containerfile:2
   • Issue: Base image uses Go 1.24.6:

     FROM registry.access.redhat.com/ubi9/go-toolset:1.24.6-1762373805 AS builder

   • Impact: Container builds will use Go 1.24.6 instead of 1.25.4
   • Recommendation: Update to a UBI9 go-toolset image with Go 1.25.x when available, or verify that 1.24.6 is acceptable

3. Documentation Update Required (Medium Priority)

   • Location: CLAUDE.md:146
   • Issue: Documentation states "Go 1.24+" as a dependency
   • Recommendation: Update to "Go 1.25+" or keep as "Go 1.24+" if backward compatibility is maintained

---

Potential Bugs & Issues 🔍

• No code changes: Since this only affects the toolchain, no logic bugs are introduced
• Backward compatibility: The go 1.24.0 directive means the code still targets Go 1.24 features, so this should be safe
• Dependency compatibility: All dependencies in go.mod should be compatible with Go 1.25

---

Performance Considerations 🚀

• Go 1.25 typically includes performance improvements and compiler optimizations
• No performance regressions expected from a minor version bump
• Potential benefits from newer Go runtime improvements

---

Security Concerns 🔒

POSITIVE - Upgrading Go versions generally includes:

• Security fixes and patches
• Improved standard library security
• Updated crypto implementations

No security concerns introduced by this change.

---

Test Coverage ✅

• Existing test suite should provide adequate coverage
• Recommendation: Ensure CI passes with the updated toolchain before merging
• The auto-merge workflow should handle this correctly once CI is updated

---

Action Items 📋

Before merging this PR:

1. ✅ The change itself is good
2. ⚠️ MUST UPDATE: .github/workflows/test.yml to use Go 1.25
3. ⚠️ MUST VERIFY: Container image compatibility or update Containerfile
4. 📝 OPTIONAL: Update CLAUDE.md documentation

Recommendation: This PR should be held until the CI workflow and Containerfile are updated to match the new toolchain version. Otherwise, you'll have version mismatches between local development, CI, and production builds.

---

Suggested Follow-up PRs

1. Update GitHub Actions workflow to Go 1.25
2. Update Containerfile base image to Go 1.25 (when available)
3. Update documentation to reflect new Go version requirement

---

Overall Assessment: The toolchain update itself is fine, but supporting infrastructure needs to be updated first to maintain consistency across all build environments.