Stop logging to STDOUT and establishing DB connection on init #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhollinger
pushed a commit
that referenced
this pull request
Jan 30, 2022
|
Applied in 2.1.0 - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR removes the setting of a default STDOUT logger when requiring the GEM. I think most apps want to control how queries are logged and not log activerecord things into STDOUT
This PR also changes the configure methods not to establish a db connection. For example on an application that has some kind of control process the connection established on initialization cannot be used in the forks anyway.
Think it's also recommended not to connect to the database on boot:
https://github.com/rails/rails/blob/main/activerecord/lib/active_record/railtie.rb#L254