Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Enable Default Subtitle #615

Closed
kkdlau opened this issue Jul 21, 2021 · 1 comment
Closed

[FEATURE] Enable Default Subtitle #615

kkdlau opened this issue Jul 21, 2021 · 1 comment
Assignees
Labels
wontfix This will not be worked on

Comments

@kkdlau
Copy link

kkdlau commented Jul 21, 2021

Is your feature request related to a problem? Please describe.
I'm making a subtitle-related application and people who using that app are expected to watch the videos with subtitles. But it will quite annoying if the user needs to manually select the default subtitle every time when they play the video.

Describe the solution you'd like
In controlsConfiguration, provides a parameter named enableDefaultSubtitle, and if this parameter is true, default subtitle will be enabled at the beginning of the video.

Hmm maybe make this parameter only functional if only a subtitle is passed to the player.

Describe alternatives you've considered
None

Additional context
None

@kkdlau kkdlau added enhancement New feature or request new issue New issue which has not been checked yet labels Jul 21, 2021
@jhomlala
Copy link
Owner

jhomlala commented Aug 7, 2021

Please use selectedByDefault parameter in BetterPlayerSubtitlesSource. See subtitles example in sample app: https://github.com/jhomlala/betterplayer/blob/master/example/lib/pages/subtitles_page.dart.

@jhomlala jhomlala closed this as completed Aug 7, 2021
@jhomlala jhomlala added wontfix This will not be worked on and removed enhancement New feature or request new issue New issue which has not been checked yet labels Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants