Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] HLS don't start with or give access to know which subtitle is the default #687

Closed
siloebb opened this issue Sep 1, 2021 · 2 comments · Fixed by #688
Closed
Assignees
Labels
enhancement New feature or request

Comments

@siloebb
Copy link
Contributor

siloebb commented Sep 1, 2021

Is your feature request related to a problem? Please describe.
When I use HLS (eg. m3u8) I receive an attribute when a subtitle is the default the DEFAULT=YES, but I can't access this field from the lib and the player don't start with the subtitle with this field marked.

Describe the solution you'd like
I wait that the video start with the subtitle that have the attribute DEFAULT=YES, a used pattern in the players, or at least give the information of which subtitle is the default.

Additional context
I saw another feature requested [FEATURE] Enable Default Subtitle , but my request differs because the HLS came ready to play and not is needed set the subtitles.

The example project have a video that can be used, the HLS subtitles, if you play in the most of players the default sub will be selected by default.
In the file of example you can see this line below with the field DEFAULT=YES
#EXT-X-MEDIA:TYPE=SUBTITLES,GROUP-ID="subs",NAME="English",DEFAULT=YES,AUTOSELECT=YES,FORCED=NO,LANGUAGE="en",URI="subtitles_en.m3u8"

@siloebb siloebb added enhancement New feature or request new issue New issue which has not been checked yet labels Sep 1, 2021
@siloebb
Copy link
Contributor Author

siloebb commented Sep 3, 2021

I made a PR to resolve this issue, I will thanks if can review.

@siloebb siloebb changed the title [FEATURE] HLS don't start or give access to know which subtitle is the default [FEATURE] HLS don't start with or give access to know which subtitle is the default Sep 9, 2021
@jhomlala
Copy link
Owner

Added in 0.0.74. Thank you for your PR.

@jhomlala jhomlala removed the new issue New issue which has not been checked yet label Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants