Exposes all active eventListener #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks. |
jhomlala
added a commit
that referenced
this pull request
Jul 9, 2021
* Fixed play after seeking issue on iOS * Fixed audio track selection issue on iOS/Android * Fixed issue where speed which couldn't be applied on iOS was saved in player state. * Added support for D-pad navigation using a Android TV remote control (#586) * Exposes all active eventListener (#585) * Updated changelog * Added docs * Updated documentation * Updated documentation * Added BetterPlayerMultipleGestureDetector, general refactor * General refactor Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com> Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>
creativeblaq
pushed a commit
to creativeblaq/betterplayer
that referenced
this pull request
Jul 9, 2021
* Fixed play after seeking issue on iOS * Fixed audio track selection issue on iOS/Android * Fixed issue where speed which couldn't be applied on iOS was saved in player state. * Added support for D-pad navigation using a Android TV remote control (jhomlala#586) * Exposes all active eventListener (jhomlala#585) * Updated changelog * Added docs * Updated documentation * Updated documentation * Added BetterPlayerMultipleGestureDetector, general refactor * General refactor Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com> Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>
creativeblaq
pushed a commit
to creativeblaq/betterplayer
that referenced
this pull request
Jul 9, 2021
* Fixed play after seeking issue on iOS * Fixed audio track selection issue on iOS/Android * Fixed issue where speed which couldn't be applied on iOS was saved in player state. * Added support for D-pad navigation using a Android TV remote control (jhomlala#586) * Exposes all active eventListener (jhomlala#585) * Updated changelog * Added docs * Updated documentation * Updated documentation * Added BetterPlayerMultipleGestureDetector, general refactor * General refactor Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com> Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>
jhomlala
added a commit
that referenced
this pull request
Aug 15, 2021
* Better UI Changes * Update ci.yml * Feature/july changes (#598) * Fixed play after seeking issue on iOS * Fixed audio track selection issue on iOS/Android * Fixed issue where speed which couldn't be applied on iOS was saved in player state. * Added support for D-pad navigation using a Android TV remote control (#586) * Exposes all active eventListener (#585) * Updated changelog * Added docs * Updated documentation * Updated documentation * Added BetterPlayerMultipleGestureDetector, general refactor * General refactor Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com> Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com> * Updated docs * Updated docs * Updated docs * Updated docs * fixed conflicts * Duplicated named argument 'onLongPress' removed * Better UI Changes * Feature/july changes (#598) * Fixed play after seeking issue on iOS * Fixed audio track selection issue on iOS/Android * Fixed issue where speed which couldn't be applied on iOS was saved in player state. * Added support for D-pad navigation using a Android TV remote control (#586) * Exposes all active eventListener (#585) * Updated changelog * Added docs * Updated documentation * Updated documentation * Added BetterPlayerMultipleGestureDetector, general refactor * General refactor Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com> Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com> * fixed conflicts Co-authored-by: Jakub <jhomlala@gmail.com> Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com> Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>
jhomlala
added a commit
that referenced
this pull request
Aug 15, 2021
* Added licenseUrl support for iOS DRM. * Fixed RTL text direction issue in player controls. * Updated normal player page * Added currently displayed subtitle * Added additional check in `postControllerEvent` to handle scenario where event stream is closed. * Updated ExoPlayer version * Buffering fix in Android, video list update * * Added `setMixWithOthers` method in `BetterPlayerListVideoPlayerController`. * Fixed broken ling in cover page of documentatio * Fixed progress bar issue where position could be set above video duration * Fixed iOS remote notification command issu * Update welcome_page.dart (#607) Removed duplicated page * Removed duplicated page in example app (by https://github.com/pinguluk) * Added support for ClearKey DRM for File Datasource. (#566) * Added support for ClearKey DRM for File Datasource. * Formatting of ClearKey implementation code. * Added ClearKey support for BetterPlayerDataSourceType.network and BetterPlayerDataSourceType.memory for Android. * Added ClearKey DRM to new documentation format. * Clear key DRM update * Better UI Changes (#594) * Better UI Changes * Update ci.yml * Feature/july changes (#598) * Fixed play after seeking issue on iOS * Fixed audio track selection issue on iOS/Android * Fixed issue where speed which couldn't be applied on iOS was saved in player state. * Added support for D-pad navigation using a Android TV remote control (#586) * Exposes all active eventListener (#585) * Updated changelog * Added docs * Updated documentation * Updated documentation * Added BetterPlayerMultipleGestureDetector, general refactor * General refactor Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com> Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com> * Updated docs * Updated docs * Updated docs * Updated docs * fixed conflicts * Duplicated named argument 'onLongPress' removed * Better UI Changes * Feature/july changes (#598) * Fixed play after seeking issue on iOS * Fixed audio track selection issue on iOS/Android * Fixed issue where speed which couldn't be applied on iOS was saved in player state. * Added support for D-pad navigation using a Android TV remote control (#586) * Exposes all active eventListener (#585) * Updated changelog * Added docs * Updated documentation * Updated documentation * Added BetterPlayerMultipleGestureDetector, general refactor * General refactor Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com> Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com> * fixed conflicts Co-authored-by: Jakub <jhomlala@gmail.com> Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com> Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com> * Updated changelog * Added `sigmaX` and `sigmaY` parameters in BetterPlayerControlsConfiguration * Updated lint and format * Updated versions Co-authored-by: Pinguluk <luca_paun@yahoo.com> Co-authored-by: tinusneethling <59045462+tinusneethling@users.noreply.github.com> Co-authored-by: creativeblaq <76699978+creativeblaq@users.noreply.github.com> Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com> Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>
geriby23
pushed a commit
to threadable/betterplayer
that referenced
this pull request
Jul 16, 2024
* Fixed play after seeking issue on iOS * Fixed audio track selection issue on iOS/Android * Fixed issue where speed which couldn't be applied on iOS was saved in player state. * Added support for D-pad navigation using a Android TV remote control (jhomlala#586) * Exposes all active eventListener (jhomlala#585) * Updated changelog * Added docs * Updated documentation * Updated documentation * Added BetterPlayerMultipleGestureDetector, general refactor * General refactor Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com> Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>
geriby23
pushed a commit
to threadable/betterplayer
that referenced
this pull request
Jul 16, 2024
* Added licenseUrl support for iOS DRM. * Fixed RTL text direction issue in player controls. * Updated normal player page * Added currently displayed subtitle * Added additional check in `postControllerEvent` to handle scenario where event stream is closed. * Updated ExoPlayer version * Buffering fix in Android, video list update * * Added `setMixWithOthers` method in `BetterPlayerListVideoPlayerController`. * Fixed broken ling in cover page of documentatio * Fixed progress bar issue where position could be set above video duration * Fixed iOS remote notification command issu * Update welcome_page.dart (jhomlala#607) Removed duplicated page * Removed duplicated page in example app (by https://github.com/pinguluk) * Added support for ClearKey DRM for File Datasource. (jhomlala#566) * Added support for ClearKey DRM for File Datasource. * Formatting of ClearKey implementation code. * Added ClearKey support for BetterPlayerDataSourceType.network and BetterPlayerDataSourceType.memory for Android. * Added ClearKey DRM to new documentation format. * Clear key DRM update * Better UI Changes (jhomlala#594) * Better UI Changes * Update ci.yml * Feature/july changes (jhomlala#598) * Fixed play after seeking issue on iOS * Fixed audio track selection issue on iOS/Android * Fixed issue where speed which couldn't be applied on iOS was saved in player state. * Added support for D-pad navigation using a Android TV remote control (jhomlala#586) * Exposes all active eventListener (jhomlala#585) * Updated changelog * Added docs * Updated documentation * Updated documentation * Added BetterPlayerMultipleGestureDetector, general refactor * General refactor Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com> Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com> * Updated docs * Updated docs * Updated docs * Updated docs * fixed conflicts * Duplicated named argument 'onLongPress' removed * Better UI Changes * Feature/july changes (jhomlala#598) * Fixed play after seeking issue on iOS * Fixed audio track selection issue on iOS/Android * Fixed issue where speed which couldn't be applied on iOS was saved in player state. * Added support for D-pad navigation using a Android TV remote control (jhomlala#586) * Exposes all active eventListener (jhomlala#585) * Updated changelog * Added docs * Updated documentation * Updated documentation * Added BetterPlayerMultipleGestureDetector, general refactor * General refactor Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com> Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com> * fixed conflicts Co-authored-by: Jakub <jhomlala@gmail.com> Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com> Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com> * Updated changelog * Added `sigmaX` and `sigmaY` parameters in BetterPlayerControlsConfiguration * Updated lint and format * Updated versions Co-authored-by: Pinguluk <luca_paun@yahoo.com> Co-authored-by: tinusneethling <59045462+tinusneethling@users.noreply.github.com> Co-authored-by: creativeblaq <76699978+creativeblaq@users.noreply.github.com> Co-authored-by: Daniel Zarins <74965667+danielz-nenda@users.noreply.github.com> Co-authored-by: Letalus <41230136+Letalus@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature:
Exposes all active eventListeners within the better_player_controller.dart file
Argument:
This functionality is useful when user are working with recycleController (controllers which will be reused after they have been disposed, or after the video has changed).
A good use case is if the user has a list of 100 videos within a pageviewer, creates 3 videoplayer, which then will be used to show all 100 videos (the pageviewer is always preloading the video before and after the current video).
This approach avoids within android the OOM Bug (because in android you can only create around 3 video player instances and after that the system won't let you create more)
Within iOS it is the same, except that you are able to create exactly 32 instances of the avplayer.
Conclusion:
By exposing the eventListeners, the developers are enabled to recycle the videos more efficiently