auto detect fullscreen aspect ratio #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, I'll merge it before releasing next version. |
jhomlala
added a commit
that referenced
this pull request
Oct 16, 2021
* Fixed full screen safe area issue in cupertino controls * Changed min. Flutter version to 2.2.3. * Fixed subtitles duplication after changing data source. * Added url parameter for changedResolution event * Updated license * Added [videoExtension] support for network data source for scenario where video source has no extension and cache manager requires it. * Fixed progress bar issues when changing position of the video * Added parameters to changedTrack event * Added [changedPlaylistItem] event. * auto detect fullscreen aspect ratio (#741) * Updated changelog, updated doc * Updated docs * Updated formatting * Changed log level in ExoPlayer to Error. * Updated screenshots * Updated documentation Co-authored-by: Maciej Brażewicz <brazol@gmail.com>
geriby23
pushed a commit
to threadable/betterplayer
that referenced
this pull request
Jul 16, 2024
* Fixed full screen safe area issue in cupertino controls * Changed min. Flutter version to 2.2.3. * Fixed subtitles duplication after changing data source. * Added url parameter for changedResolution event * Updated license * Added [videoExtension] support for network data source for scenario where video source has no extension and cache manager requires it. * Fixed progress bar issues when changing position of the video * Added parameters to changedTrack event * Added [changedPlaylistItem] event. * auto detect fullscreen aspect ratio (jhomlala#741) * Updated changelog, updated doc * Updated docs * Updated formatting * Changed log level in ExoPlayer to Error. * Updated screenshots * Updated documentation Co-authored-by: Maciej Brażewicz <brazol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I wanted to auto detect video aspect ratio in full screen but without changing device orientation. So basically what autoDetectFullscreenDeviceOrientation did without the orientation change part.
I added another flag autoDetectFullscreenAspectRatio which does that. I hope it looks good. Let me know if I should change anything.