-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependencies on GCDWebServer and PINCache #787
Add dependencies on GCDWebServer and PINCache #787
Conversation
Trying to fix part of jhomlala#714
@twogood Before merging this PR I need to know when does this problem occur. Can you prepare some reproducible example? |
You know the old saying: | The definition of insanity is doing the same thing over and over again and expecting a different result. The client project that me and my team have inherited and are currently working on failed on compile most of the time before adding these as explicit dependencies. We have spent many hours trying to figure out why. With this patch it works every time. Linkers are a species of their own. There is even a "classic" book called "Linkers and loaders" for those who want to know more how linkers work. But I digress. I don't have an isolated example but as the better player code explicitly references these pods they should also be explicit references from the better player pod. It is unwise to depend on transitive dependencies. |
This article shows a cocoa pods example for specifying the same dependency on different levels in the dependency tree with proper version resolving: |
Here is an example that (sometimes) fails the same way: https://github.com/twogood/better_player_pr787 Can happen with "Play" button in XCode, also with |
And sometimes... "Build succeeded" |
For what it's worth, I also experienced this error yesterday (and then it resolved itself after a clean build). Seems like a good idea to explicitly add the transitive dependencies if it can make the build more reliable! |
+1 @twogood's solution works. |
I added this patch too! No more linker errors :) |
It also fixed the error for me when building for a real device 👍 |
It’s help |
LGTM, thanks. |
* Updated dependencies * Fix bug where a render error can occur if the width of the player is less than 240 pixels. (#810) * Updated changelog * Switch from jcenter to mavenCentral (#798) * Updated changelog * Fixed badState error (#796) * Add dependencies on GCDWebServer and PINCache (#787) Trying to fix part of #714 * Updated changelog * Lint & format changes * Updated installation documentation page * Updated installation documentation page * Updated installation documentation page Co-authored-by: Alan <adman1108@gmail.com> Co-authored-by: Peter Majchrak <pm@lix.com> Co-authored-by: masoudk2000 <52602761+masoudk2000@users.noreply.github.com> Co-authored-by: David Eriksson <david@activout.se>
* Updated dependencies * Fix bug where a render error can occur if the width of the player is less than 240 pixels. (#810) * Updated changelog * Switch from jcenter to mavenCentral (#798) * Updated changelog * Fixed badState error (#796) * Add dependencies on GCDWebServer and PINCache (#787) Trying to fix part of #714 * Updated changelog * Lint & format changes * Updated installation documentation page * Updated installation documentation page * Updated installation documentation page * Fixed full screen button padding in material controls. * Added setBetterPlayerControlsConfiguration method * Added `setOverriddenFit` in `BetterPlayerController`. * Added `setOverriddenFit` in `BetterPlayerController`. * General refactor * Format Co-authored-by: Alan <adman1108@gmail.com> Co-authored-by: Peter Majchrak <pm@lix.com> Co-authored-by: masoudk2000 <52602761+masoudk2000@users.noreply.github.com> Co-authored-by: David Eriksson <david@activout.se>
* Updated dependencies * Fix bug where a render error can occur if the width of the player is less than 240 pixels. (jhomlala#810) * Updated changelog * Switch from jcenter to mavenCentral (jhomlala#798) * Updated changelog * Fixed badState error (jhomlala#796) * Add dependencies on GCDWebServer and PINCache (jhomlala#787) Trying to fix part of jhomlala#714 * Updated changelog * Lint & format changes * Updated installation documentation page * Updated installation documentation page * Updated installation documentation page Co-authored-by: Alan <adman1108@gmail.com> Co-authored-by: Peter Majchrak <pm@lix.com> Co-authored-by: masoudk2000 <52602761+masoudk2000@users.noreply.github.com> Co-authored-by: David Eriksson <david@activout.se>
* Updated dependencies * Fix bug where a render error can occur if the width of the player is less than 240 pixels. (jhomlala#810) * Updated changelog * Switch from jcenter to mavenCentral (jhomlala#798) * Updated changelog * Fixed badState error (jhomlala#796) * Add dependencies on GCDWebServer and PINCache (jhomlala#787) Trying to fix part of jhomlala#714 * Updated changelog * Lint & format changes * Updated installation documentation page * Updated installation documentation page * Updated installation documentation page * Fixed full screen button padding in material controls. * Added setBetterPlayerControlsConfiguration method * Added `setOverriddenFit` in `BetterPlayerController`. * Added `setOverriddenFit` in `BetterPlayerController`. * General refactor * Format Co-authored-by: Alan <adman1108@gmail.com> Co-authored-by: Peter Majchrak <pm@lix.com> Co-authored-by: masoudk2000 <52602761+masoudk2000@users.noreply.github.com> Co-authored-by: David Eriksson <david@activout.se>
Trying to fix part of #714
To be more exact, try to fix this error message, which sometimes also lists GCDWebServer: