Skip to content

Move tests to standalone binary #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Move tests to standalone binary #14

merged 1 commit into from
Feb 22, 2023

Conversation

jhpratt
Copy link
Owner

@jhpratt jhpratt commented Jan 31, 2023

Fixes #13

Currently a linker failure for the iOS build. I am unable to reproduce that failure locally (using Linux).

@jhpratt jhpratt requested a review from Freaky January 31, 2023 23:51
@Freaky
Copy link
Collaborator

Freaky commented Feb 1, 2023

The macOS linker failure looks identical to rust-lang/rust#105167 - I think the fix would be to bump the Rust version there, or request an older macOS image.

The sleeps are a bit disconcerting - are the thread counts reported by /proc actually potentially out of date, or is Linux just lazy about reaping LWPs?

@jhpratt
Copy link
Owner Author

jhpratt commented Feb 5, 2023

Requesting an older image is a losing battle, as they eventually get turned off in favor of newer images. I can look into checking a higher Rust version in CI, but I'm not sure where to begin on that other than doing a binary search manually.

With regard to the sleeps — I have no idea why they're necessary. The tests pass on my Fedora machine without them, but it failed in CI.

My priorities are elsewhere in the ecosystem at the moment, so feel free to push on this branch and release when ready.

@Freaky Freaky merged commit 2ae7e86 into main Feb 22, 2023
@jhpratt jhpratt deleted the issue-13 branch February 1, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests fail with Rust 1.67.0+
2 participants