Updates migrations with using field_unique_id as default for parse_entity_lookups #204
Conversation
field_unique_id, instead of name/title. Still a WIP and will need changes.
bseeger
force-pushed
the
migration_unique_id_updates
branch
from
c5f1675 to
5046172
Compare
|
|
|
|
|
|
|
and to not fail there's an unexpected message (like a message about drupal needing updating)
|
|
(it had a typo, but I'm not sure it's needed in the first place)
|
|
|
|
|
|
|
bseeger
changed the title
| @@ -166,7 +180,7 @@ export const download = async (uri) => { | |||
| * @param {string} name Name of the repository object for whom to upload an image to | |||
| * @param {string} file path of the file to upload, on disk. | |||
| */ | |||
| export const uploadImageInUI = async (t, name, file) => { | |||
| export const uploadImageInUI = async (t, name, file, access) => { | |||
There was a problem hiding this comment.
rename to accessTerm, add something like @param {string} accessTerm textual name of access term to use for the uploaded file
| @@ -185,7 +200,7 @@ export const uploadImageInUI = async (t, name, file) => { | |||
| * @param {string} name Name of the repository object for whom to upload a file to | |||
| * @param {string} file path of the file to upload, on disk. | |||
| */ | |||
| export const uploadFileInUI = async (t, name, file) => { | |||
| export const uploadFileInUI = async (t, name, file, access) => { | |||
There was a problem hiding this comment.
rename to accessTerm, add something like @param {string} accessTerm textual name of access term to use for the uploaded file
| @@ -166,7 +182,7 @@ export const download = async (uri) => { | |||
| * @param {string} name Name of the repository object for whom to upload an image to | |||
| * @param {string} file path of the file to upload, on disk. | |||
| */ | |||
| export const uploadImageInUI = async (t, name, file) => { | |||
| export const uploadImageInUI = async (t, name, file, access) => { | |||
There was a problem hiding this comment.
rename to accessTerm, add something like @param {string} accessTerm textual name of access term to use for the uploaded file
| @@ -185,7 +202,7 @@ export const uploadImageInUI = async (t, name, file) => { | |||
| * @param {string} name Name of the repository object for whom to upload a file to | |||
| * @param {string} file path of the file to upload, on disk. | |||
| */ | |||
| export const uploadFileInUI = async (t, name, file) => { | |||
| export const uploadFileInUI = async (t, name, file, access) => { | |||
There was a problem hiding this comment.
rename to accessTerm, add something like @param {string} accessTerm textual name of access term to use for the uploaded file
adds a description for the parameter
|
Resovles: jhu-idc/iDC-general#388
This update migrations to have the
parse_entity_lookupandentity_lookupprocesses usefield_unique_idinstead oftitleornameas the default for value_key.Also update test migrations to use the
field_unique_idfield information in entity references.Adds
field_unique_idto search index as well as to the exported information.To test this -- run the test suite or create an ingest using
field_unique_idto reference an Entity Reference.To be clear, all the places where user manage taxonomy terms might be applied use the
parse_entity_lookup. All the places that use a system managed taxonomy (Islandora Media Use, Islandora Display and Islandora Models) still useentity_lookupas they don't have afield_unique_id.