Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtt_roscomm: Boost header generation broken with genmsg 0.4.22 #16

Closed
wants to merge 1 commit into from

Conversation

meyerj
Copy link

@meyerj meyerj commented Sep 5, 2013

ros/genmsg#32 has broken typekit generation as ${${package}_MESSAGE_FILES} variable contains relative paths now. The current Ubuntu repositories serve genmsg 0.4.22 including that patch since today.

We have to check if this can be considered a bug in genmsg or if there is a simple way to get the absolute path in a generic way.

Possible solution (not tested yet):

if(NOT IS_ABSOLUTE "${FILE}")
  set(FILE "${${package}_DIR}/${FILE}")
endif()

@jbohren
Copy link
Member

jbohren commented Sep 5, 2013

Blah. Yeah, this might be an acceptable solution. It definitely seems easier than having to go through the process of changing genmsg.

@meyerj
Copy link
Author

meyerj commented Sep 5, 2013

I guess it's not a bug. There have been huge efforts to ban every occurence of absolute paths from the install-space in order to make it relocatable: ros/catkin#490.

@jbohren
Copy link
Member

jbohren commented Sep 5, 2013

I guess it's not a bug. There have been huge efforts to ban every occurence of absolute paths from the install-space in order to make it relocatable: ros/catkin#490.

Yeah, that's what it seems like. At least this shouldn't be too hard to fix. Meanwhile, did you have a chance to look at #5 ?

@jbohren jbohren closed this in c44b35b Sep 13, 2013
@meyerj meyerj deleted the fix-16 branch October 3, 2013 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants