Skip to content

Commit

Permalink
Version 0.9.50
Browse files Browse the repository at this point in the history
- Changed behavior so manually started jobs will be rewinded if failed and Run All Mode is set.
- Fixes #757
- Updated docs regarding timeouts and Run All Mode.
  • Loading branch information
jhuckaby committed May 13, 2024
1 parent db3b4b8 commit 846f974
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/WebUI.md
Original file line number Diff line number Diff line change
Expand Up @@ -232,12 +232,12 @@ If any of the following situations occur, and the event has Run All (Catch-Up) m
* Job could not run due to the event category or Plugin being disabled.
* Server running the job was shut down.
* Server running the job crashed.
* Job was aborted due to exceeding a timeout limit.
* Job was aborted due to exceeding a resource limit (RAM or CPU).

The only time a Catch-Up job is *not* re-run is when one of the following actions occur:

* Job is manually aborted via the Web UI or API.
* Job was aborted due to exceeding a timeout limit (see [Issue #369](https://github.com/jhuckaby/Cronicle/issues/369) for explanation).
* Job fails due to error thrown from inside the Plugin (user code generated error).

You can see all queued jobs on the [Home Tab](WebUI.md#home-tab). They will be listed in the [Upcoming Events](WebUI.md#upcoming-events) table, and have their "Countdown" column set to "Now". To jump over the queue and reset an event that has fallen behind, use the [Event Time Machine](WebUI.md#event-time-machine) feature.
Expand Down
6 changes: 4 additions & 2 deletions lib/job.js
Original file line number Diff line number Diff line change
Expand Up @@ -775,10 +775,12 @@ module.exports = Class.create({

rewindJob: function(job) {
// reset cursor state to minute before job started (use 'now' property in case start was delayed)
// only do this if job has catch_up, was launched via the scheduler, and is not multiplexed
// only do this if job has catch_up, and is not multiplexed
if (!this.multi.master) return;

if (job.catch_up && !job.source && !job.multiplex) {
// Note: manually started jobs will now be included in the rewind, as per GH #757

if (job.catch_up && !job.multiplex) {
var new_start = Tools.normalizeTime( job.now - 60, { sec: 0 } );
this.state.cursors[ job.event ] = new_start;

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "Cronicle",
"version": "0.9.49",
"version": "0.9.50",
"description": "A simple, distributed task scheduler and runner with a web based UI.",
"author": "Joseph Huckaby <jhuckaby@gmail.com>",
"homepage": "https://github.com/jhuckaby/Cronicle",
Expand Down

0 comments on commit 846f974

Please sign in to comment.