Jimin - Edits (grammar and wordings) #44
Conversation
|
No spelling errors! 🎉 |
|
No broken URLs detected! 🎉 |
|
Re-rendered previews from the latest commit:
Updated at 2022-04-07 with changes from 4d64085 |
03-version-control-with-github.Rmd
Outdated
| One more note, if you do want to use command line or you want to know more about the specific git commands that GitKraken is doing for you (might be handy for troubleshooting), **the specific commands that can be used or Googled at each step are highlighted in red in the images**, you just need to add `git` before them! So for example you would type `git push` in your command line in order to push your code. Or if you'd like to know more about pushing code, you can google `git push`. | ||
| One more note: if you do want to use the command line or if you want to know more about the specific git commands that GitKraken is doing for you (which might be handy for troubleshooting), **the specific commands that can be used or Googled at each step are highlighted in red in the images** - you just need to add `git` before them! For example, you would type `git push` in your command line in order to push your code. Or if you'd like to know more about pushing code, you can google `git push`. | ||
|
|
||
| ```{r, fig.alt="Alternative text", echo = FALSE} |
There was a problem hiding this comment.
This is awesome! I left a comment on the Google slide.
|
you will need the updated css code (in your case the one in the style-sets/itcr dir) from the template and the images added to the assets directory of the template (of course though you just need the github image if that is the only box you need for this course). I can move these from assets to style-sets because that is already set up to sync. If we do that... then after the sync you just need to recopy the css file to the main dir from the style-sets dir |
I started this process so that we can do this more easily - there is a new PR - I instead made a new folder in assets for the box images because I think this will be less confusing to people after they copy the css file as I think most people will want the option to do these boxes |
Added alternative text to branch diagram
Purpose/implementation Section
What changes are being implemented in this Pull Request?
**Edits mostly on Grammar and sentence structure/understandability of descriptions
Comments tagged AVOCADO
New illustration (pending review) at the end of file
**
What was your approach?
I reviewed the documents and fixed some run-on sentences, etc. Also added definitions to the terminology that seemed necessary
What GitHub issue does your pull request address?
Grammar and Sentence structure
Tell potential reviewers what kind of feedback you are soliciting.
I marked "AVOCADO" and put comments/questions in some of the places. Definitions may not be accurate so I think it would be safer if reviewed.
New Content Checklist
New content/chapter is in an Rmd file with this kind of format and headers.
New content/chapter contains Learning Objectives and are in the correct format.
Bookdown successfully re-renders and any new content files have been added to the _bookdown.yml.
Spell check runs successfully in Github actions style-n-check).
Any newly necessary packages that are needed have been added to the Dockerfile and image.
Images are in the correct format for rendering.
Every new image has alt text and is in a Google Slide.
Each slide is described in the notes of the slide so learners relying on a screen reader can access the content. See https://lastcallmedia.com/blog/accessible-comics for more guidance on this.
The color palette choices of the slide are contrasted in a way that is friendly to those with color vision deficiencies.
You can check this using Color Oracle.