Updates etc for style #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f95a790. forgot I was on main#
This reverts commit fbc1c3e. forgot I was on main
…_Bookdown into main pulling new changes
…_Bookdown into main getting remote changes
…_Bookdown into main merging in remote changes
…_Bookdown into main getting remote changes
|
I think we can close the other datatrail pull request after this |
|
Re-rendered previews from the latest commit:
Updated at 2021-11-16 with changes from cb877e8 |
|
I can merge this and look at the other automated issues to see if we need to update the images |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What changes are being implemented in this Pull Request?
Since we rearranged how we are adding DataTrail branding, I added the updated version with the new feedback form link here, as well as updated some images that got removed with the last pull request about this for the automatic issues that users see.
What was your approach?
I changed the link for the forms in the DataTrail _output.yml file and adding back the automatic issues images. This may be out of date now again? need to look at this, as I think there may be more issues.
Perhaps we can create a similar library for AnVIL courses too?
What GitHub issue does your pull request address?
#327 and #323
Tell potential reviewers what kind of feedback you are soliciting.
Look good to you @cansavvy ?