Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate and config a pull request GHA #448

Merged
merged 28 commits into from
Feb 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
c8e64b7
Create config_automation.yml
avahoffman Feb 9, 2022
08cd46b
Update style-and-sp-check.yml
avahoffman Feb 9, 2022
f4bb079
Update the filename :expressionless:
avahoffman Feb 9, 2022
21dcbf1
Checking dependency
avahoffman Feb 9, 2022
847231d
Update style-and-sp-check.yml
avahoffman Feb 9, 2022
f61b7fb
Testing that file is carried over
avahoffman Feb 9, 2022
6f364e2
Add toggle to second check
avahoffman Feb 9, 2022
ebe1c1f
Change config to test
avahoffman Feb 9, 2022
ba8d729
Test removal of some extra text
avahoffman Feb 9, 2022
637070c
Change config to test (again)
avahoffman Feb 9, 2022
8e3c567
Update config_automation.yml
avahoffman Feb 9, 2022
45abd66
What does the output look like with more checks added?
cansavvy Feb 10, 2022
ea0e870
Merge branch 'main' into cansavvy/playing-with-yamls
cansavvy Feb 10, 2022
14665ab
Fix spacing
cansavvy Feb 10, 2022
b0acf77
Merge remote-tracking branch 'origin/cansavvy/playing-with-yamls' int…
cansavvy Feb 10, 2022
b38792f
Forgot "steps:"
cansavvy Feb 10, 2022
6444a39
BIG YAML
cansavvy Feb 10, 2022
f65790c
Get rid of other ones
cansavvy Feb 10, 2022
e300523
Fix names
cansavvy Feb 10, 2022
2b44775
Add needs
cansavvy Feb 10, 2022
dd2b91e
Try adding docker to it
cansavvy Feb 10, 2022
0c9e66d
Fix syntax
cansavvy Feb 10, 2022
d322923
Gotta check it out first
cansavvy Feb 10, 2022
877f48f
Extra "if" lying around
cansavvy Feb 10, 2022
f45e5c7
Set logically differently
cansavvy Feb 10, 2022
73469ce
Merge branch 'staging' into cansavvy/playing-with-yamls
cansavvy Feb 10, 2022
3369a02
Testing change
avahoffman Feb 10, 2022
d7a7127
Add Ava's suggestions!
cansavvy Feb 10, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 0 additions & 116 deletions .github/workflows/check-quizzes.yml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,26 +1,18 @@
# Candace Savonen Apr 2021

name: Build of Docker
name: Build Docker


#---TRIGGER-START---#
on:
release:
types:
- created
pull_request:
branches: [ main, staging ]
paths: [ docker/Dockerfile, docker/github_package_list.tsv ]
workflow_dispatch:
inputs:
dockerhubpush:
description: 'Push to Dockerhub?'
required: true
default: 'false'
#---TRIGGER-END----#

jobs:
build-docker:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
build-docker:
build-docker:
name: Build Docker image

name: Build Docker image
runs-on: ubuntu-latest

steps:
Expand All @@ -33,18 +25,15 @@ jobs:
git config --local user.name "jhudsl-robot"

- name: Don't re-test if this is a sync branch
if: ${{ github.head_ref == 'repo-sync/OTTR_Template/default' }}
run: |
echo This was tested on OTTR_Template no need to re-run

# Set up Docker build
- name: Set up Docker Buildx
if: ${{ github.head_ref != 'repo-sync/OTTR_Template/default' }}
uses: docker/setup-buildx-action@v1

# Setup layer cache
- name: Cache Docker layers
if: ${{ github.head_ref != 'repo-sync/OTTR_Template/default' }}
uses: actions/cache@v2
with:
path: /tmp/.buildx-cache
Expand All @@ -58,12 +47,10 @@ jobs:
uses: docker/setup-buildx-action@v1

- name: Get token
if: ${{ github.head_ref != 'repo-sync/OTTR_Template/default' }}
run: echo ${{ secrets.GH_PAT }} > docker/git_token.txt

# Build docker image
- name: Build Docker image
if: ${{ github.head_ref != 'repo-sync/OTTR_Template/default' }}
uses: docker/build-push-action@v2
with:
push: false
Expand All @@ -86,14 +73,6 @@ jobs:
run: docker push jhudsl/course_template

- name: Get the version
if: ${{ github.head_ref != 'repo-sync/OTTR_Template/default' }}
id: get_version
run: |
echo ::set-output name=version::$(echo $GITHUB_REF | cut -d / -f 3)

# Push the Docker image if it is a release
- name: Push Docker image if release
if: ${{ github.event_name == 'release' }}
run: |
docker tag jhudsl/course_template:latest jhudsl/course_template:${{ steps.get_version.outputs.version }}
docker push jhudsl/course_template:${{ steps.get_version.outputs.version }}
Loading