Disentangle bookdown/coursera/leanpub rendering. #459
Conversation
|
No quiz errors detected! 🎉 |
|
No spelling errors! 🎉 |
cansavvy
changed the title
| render-coursera: | ||
| name: Render Coursera | ||
| needs: [yaml-check, render-bookdown] | ||
| render-tocless: |
There was a problem hiding this comment.
This is a new section that will run before Leanpub or Coursera if either is set to yes
There was a problem hiding this comment.
I wonder if it makes sense to call this something like "Start Leanpub/Coursera render" and then have the jobs below be "Finish Leanpub" and "Finish Coursera"
| run: | | ||
| Rscript -e "ottr::bookdown_to_embed_leanpub( \ | ||
| Rscript -e "ottr::bookdown_to_embed_leanpub( | ||
| render = FALSE \ |
There was a problem hiding this comment.
I realized its redundant to have bookdown re-rendered if we just did it. So we're using the option here to skip the bookdown::render() step done by this function if bookdown was just run previously.
There was a problem hiding this comment.
Nope. I just realized it never needs to be re-rendered here because the render-tocless section does this.
| render-coursera: | ||
| name: Render Coursera | ||
| needs: [yaml-check, render-bookdown] | ||
| render-tocless: |
There was a problem hiding this comment.
I wonder if it makes sense to call this something like "Start Leanpub/Coursera render" and then have the jobs below be "Finish Leanpub" and "Finish Coursera"
Yes, I like this. |
|
Re-rendered previews from the latest commit:
Updated at 2022-02-11 with changes from eb11c94 |
Purpose/implementation Section
What changes are being implemented in this Pull Request?
render_coursera()function is actually just "render_without_toc" but Leanpub also needs a toc-less version.I'm working on disentangling the renders from each other so someone can truly specify just one and not the others. Before Leanpub was dependent on Coursera which was dependent on Bookdown.
Now, my hope is you can really just choose one and not the others (although really Bookdown is still run underneath the hood for all)
Over in the
ottrpackage, I renamedrender_courseratorender_without_toc()so this is less confusing. jhudsl/ottrpal#96