Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker image as option #479

Merged
merged 4 commits into from
Feb 16, 2022
Merged

Add docker image as option #479

merged 4 commits into from
Feb 16, 2022

Conversation

cansavvy
Copy link
Collaborator

Purpose/implementation Section

What changes are being implemented in this Pull Request?

To address #476 This allows you to choose what image to render your previews and material with.

Default docker image is jhudsl/course_template:main

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2022 •
edited
Loading

No spelling errors! 🎉
Comment updated at 2022-02-16 with changes from dfc5c3f

@github-actions
Copy link
Contributor

Re-rendered previews from the latest commit:

Updated at 2022-02-16 with changes from dfc5c3f

@cansavvy
Copy link
Collaborator Author

This works nicely!

@cansavvy cansavvy requested a review from avahoffman February 16, 2022 18:42
@cansavvy
Copy link
Collaborator Author

@carriewright11 This will be relevant for your ocs_guide course. Would you be able to test it on that repository after this is merged?

@cansavvy cansavvy mentioned this pull request Feb 16, 2022
Merged
@carriewright11
Copy link
Member

carriewright11 commented Feb 16, 2022 •
edited
Loading

@carriewright11 This will be relevant for your ocs_guide course. Would you be able to test it on that repository after this is merged?

Yeah, I can do that. Does the wiki say how to specify the new docker image name? do I just replace it in config_automation.yml

@cansavvy
Copy link
Collaborator Author

@carriewright11 This will be relevant for your ocs_guide course. Would you be able to test it on that repository after this is merged?

Yeah, I can do that. Does the wiki say how to specify the new docker image name? do I just replace it in config_automation.yml

That's the idea!

@cansavvy cansavvy merged commit 5c74093 into main Feb 16, 2022
@cansavvy cansavvy deleted the cansavvy/docker_manage branch February 16, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avahoffman avahoffman Awaiting requested review from avahoffman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cansavvy @carriewright11