Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save url check to a file like the other checks do #490

Merged
merged 24 commits into from
Mar 4, 2022
Merged

Conversation

cansavvy
Copy link
Collaborator

@cansavvy cansavvy commented Mar 3, 2022

Purpose/implementation Section

What changes are being implemented in this Pull Request?

If there is a broken URL, its tricky to find and I think its been sneaking by us.
This PR adds the mechanics to have it print out like we do for spell and quiz checks.

Note: I don't like how much of the handling is repetitive, I think later I will try to condense some of the comment and git checkout items.

Also later, I'll want to put all the checks into one comment #492

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

No spelling errors! 🎉
Comment updated at 2022-03-03 with changes from 66a79c8

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

Re-rendered previews from the latest commit:

Updated at 2022-03-03 with changes from 66a79c8

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

No broken URLs detected! 🎉
Comment updated at 2022-03-03 with changes from 66a79c8

@cansavvy cansavvy requested a review from avahoffman March 3, 2022 17:40
@cansavvy
Copy link
Collaborator Author

cansavvy commented Mar 4, 2022

This is working well on other repositories, so I'm going to merge it!

@cansavvy cansavvy merged commit 98e182a into main Mar 4, 2022
@cansavvy cansavvy deleted the cansavvy/url-check branch March 4, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant