Style documentation update for boxes #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f95a790. forgot I was on main#
This reverts commit fbc1c3e. forgot I was on main
…_Bookdown into main pulling new changes
…_Bookdown into main getting remote changes
…_Bookdown into main merging in remote changes
…_Bookdown into main getting remote changes
…_Bookdown into main getting remote changes
…_Bookdown into main getting remote changes
…_Bookdown into main getting remote changes - conflicted with out-of-date style files
…_Bookdown into main getting remote changes
…_Bookdown into main getting remote changes
…_Bookdown into main getting remote changes
…_Bookdown into main getting remote changes
…_Bookdown into main getting remote changes
…_Bookdown into main getting remote changes
…_Bookdown into main getting remote changes
|
No spelling errors! 🎉 |
|
No broken URLs detected! 🎉 |
|
Re-rendered previews from the latest commit:
Updated at 2022-05-16 with changes from b73511f |
…as more about stylized boxes.
cansavvy
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What changes are being implemented in this Pull Request?
I want to add more to the template to show general examples and how they get rendered (as well as more navigation to those examples). I also want to add more information about how to create stylized boxes and the syntax that you can use for that based on the basecamp discussion.
Also noticed that most of ch2 wasn't getting rendered: https://jhudatascience.org/OTTR_Template/ - so I fixed that.
What was your approach?
modifying ch2 mostly
also noticed that the borders disappeared from the boxes so modified the css slightly
Tell potential reviewers what kind of feedback you are soliciting.
Look OK @cansavvy ?