-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New tab target #588
New tab target #588
Conversation
No broken urls! 🎉 |
No spelling errors! 🎉 |
Re-rendered previews from the latest commit:
Updated at 2022-10-21 with changes from 3794dc5 |
@@ -124,6 +124,10 @@ Yet again you can use a link to a website like so: | |||
|
|||
[A Website](https://yihui.org) | |||
|
|||
You might want to have users open a website in a new tab by default, especially if they need to reference both the course and a resource at once. | |||
|
|||
[A Website](https://yihui.org){target="_blank"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve had mixed success with this format. Generally had to just use the full html format. Do we know this kind of markdown with an option works in leanpub?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep! I had that issue before, but it seems to be working now in both the preview here and in Cluster 101.
Yay! Let's merge this and move on! URL check also appears to be working better now. |
We can also maybe tell people how to make all links do this? |
@carriewright11 yes that's a good idea! |
Purpose/implementation Section
Adding instructions in case the author wants to open a link in a new tab by default. Seems to be some buggy behavior with Leanpub opening links without specifying open in a new tab (with right click).