Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tab target #588

Merged
merged 1 commit into from
Oct 22, 2022
Merged

New tab target #588

merged 1 commit into from
Oct 22, 2022

Conversation

avahoffman
Copy link
Contributor

Purpose/implementation Section

Adding instructions in case the author wants to open a link in a new tab by default. Seems to be some buggy behavior with Leanpub opening links without specifying open in a new tab (with right click).

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2022

No broken urls! 🎉
Comment updated at 2022-10-22 with changes from 3794dc5

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2022

No spelling errors! 🎉
Comment updated at 2022-10-21 with changes from 3794dc5

@github-actions
Copy link
Contributor

Re-rendered previews from the latest commit:

Updated at 2022-10-21 with changes from 3794dc5

@@ -124,6 +124,10 @@ Yet again you can use a link to a website like so:

[A Website](https://yihui.org)

You might want to have users open a website in a new tab by default, especially if they need to reference both the course and a resource at once.

[A Website](https://yihui.org){target="_blank"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve had mixed success with this format. Generally had to just use the full html format. Do we know this kind of markdown with an option works in leanpub?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep! I had that issue before, but it seems to be working now in both the preview here and in Cluster 101.

@cansavvy
Copy link
Collaborator

Yay! Let's merge this and move on! URL check also appears to be working better now.

@cansavvy cansavvy merged commit 9aa855f into main Oct 22, 2022
@cansavvy cansavvy deleted the ava/new-tab branch October 22, 2022 01:15
@carriewright11
Copy link
Member

carriewright11 commented Oct 24, 2022

We can also maybe tell people how to make all links do this?
<!-- Open all links in new tab-->
<base target="_blank"/>

@avahoffman
Copy link
Contributor Author

@carriewright11 yes that's a good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants