Edit the git config steps

[cansavvy]

Purpose/implementation Section

What changes are being implemented in this Pull Request?

There's been some issues with git config steps on personal repos: #628

I've been doing some testing here: cansavvy/test-ottr@6245c52

This change made it work, I'm just wondering if it will be okay for org repos as well as wondering if we need it every time we make a commit?

[github-actions]

Re-rendered previews from the latest commit:

• See preview of Bookdown here
• See preview of Coursera/Leanpub version here
• Download the preview of .docx file

Updated at 2023-04-13 with changes from 1bf3c8b

[github-actions]

No broken urls! 🎉
Comment updated at 2023-04-13 with changes from 1bf3c8b

[github-actions]

No spelling errors! 🎉
Comment updated at 2023-04-13 with changes from 1bf3c8b

[cansavvy]

The main change here is

 git config --global --add safe.directory ${GITHUB_WORKSPACE}
git config --global user.email "itcrtrainingnetwork@gmail.com"
git config --global user.name "jhudsl-robot"

It is making things work See: https://github.com/fhdsl/AI_for_software/pull/8#event-8940313683

But @avahoffman I don't know why. Can you sanity check this?

[avahoffman]

@cansavvy have you tested doing away with the braces entirely?

e.g.:

git config --global --add safe.directory $GITHUB_WORKSPACE
git config --global user.email "itcrtrainingnetwork@gmail.com"
git config --global user.name "jhudsl-robot"

Also, I used --system and --global flags previously because sometimes the action didn't have permission to set global. No idea if this is still an issue.

[cansavvy]

@avahoffman I'll try it!

[cansavvy]

Oh it looks like you've done this already here: 5f65ee9 Looks like everything worked fine?

[avahoffman]

@cansavvy It worked here, but is there any concern that -no brackets- might not work in personal repos?

[cansavvy]

It shouldn't matter. I'm testing it here: cansavvy/test-ottr#1 to make sure.

[cansavvy]

Appears to be working fine! This looks good to me, @avahoffman !

[avahoffman]

@cansavvy sounds good! Let's keep an eye on the --global flag just in case that breaks things 😬

[cansavvy]

If this passes, I will merge it.