Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make book txt -- add to config file as an option #641

Merged
merged 4 commits into from
May 24, 2023

Conversation

cansavvy
Copy link
Collaborator

@cansavvy cansavvy commented May 24, 2023

Purpose/implementation Section

What changes are being implemented in this Pull Request?

It's been brought to my attention that if you'd like to make your own Book.txt file manually (as opposed to the automatic creation of Book.txt as is default) this is not intuitive to set up.

So I'm adding this as an option in the config_automation.yml file.

I'll also need to file an appropriate update to ottrproject.org if this works fine.

What was your approach?

I added the option to the config_automation.yml file and then carried that option through in render-all.yml

Associated documentation PR:

jhudsl/ottrproject.org#36

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023

Re-rendered previews from the latest commit:

Updated at 2023-05-24 with changes from 892da4d

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023

No broken urls! 🎉
Comment updated at 2023-05-24 with changes from 892da4d

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2023

No spelling errors! 🎉
Comment updated at 2023-05-24 with changes from 892da4d

@cansavvy cansavvy requested a review from avahoffman May 24, 2023 14:44
@cansavvy
Copy link
Collaborator Author

Copy link
Contributor

@avahoffman avahoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cansavvy cansavvy merged commit d6a6882 into main May 24, 2023
@cansavvy cansavvy deleted the cansavvy/make-book-txt branch May 24, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants