Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transfer quiz repo files #712

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Fix transfer quiz repo files #712

merged 1 commit into from
Feb 16, 2024

Conversation

avahoffman
Copy link
Contributor

@avahoffman avahoffman commented Feb 16, 2024

What's Up

Noticed the transfer-rendered-files.yml workflow was failing over at https://github.com/fhdsl/NIH_Data_Sharing.

Did a little digging and from what I understand, GitHub doesn't want us to download individual files using either git archive or svn export for security reasons.

This solution:

  • leverages the path: arg, which allows you to checkout multiple repos using checkout
  • does some good ole' cp and mkdir to transfer stuff from the bookdown repo to the quizzes repo
  • gets rid of the svn dependency

Tested over here: fhdsl/NIH_Data_Sharing#117
Successful PR here: https://github.com/fhdsl/NIH_Data_Sharing_Quizzes/pull/3

Screenshots for your enjoyment

Workflow log, this error is not just that the link is wrong -- even with a viable link it won't download
Screenshot 2024-02-16 at 10 21 29 AM
GitHub not being helpful
Screenshot 2024-02-16 at 12 18 46 PM

@avahoffman avahoffman requested a review from cansavvy February 16, 2024 19:58
Copy link
Contributor

github-actions bot commented Feb 16, 2024

No broken urls! 🎉
Comment updated at 2024-02-16 with changes from b242527

Copy link
Contributor

github-actions bot commented Feb 16, 2024

No spelling errors! 🎉
Comment updated at 2024-02-16 with changes from b242527

Copy link
Contributor

Re-rendered previews from the latest commit:

Updated at 2024-02-16 with changes from b242527

Copy link
Collaborator

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! I always hated that svn dependency anyway! This is better! Thanks for implementing and testing!

This means a sync is in order!

@cansavvy cansavvy merged commit 21ac2c2 into main Feb 16, 2024
7 checks passed
@cansavvy cansavvy deleted the ava/quiz-transfer branch February 16, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants