Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GHA yml's compatible with quarto #746

Merged
merged 11 commits into from
Jul 16, 2024
Merged

Conversation

cansavvy
Copy link
Collaborator

@cansavvy cansavvy commented Apr 18, 2024

Summary

For maintenance purposes we want to keep one sole truth for GHA as much as possible. SO for the new Quarto OTTR course format we want to make sure that our GHA's are compatible with that.

In this PR I am working on making the GHA's also work with quarto by adding a config option for rendering. render-website: 'quarto' or 'rmd'

This means both pull-request.yml and render-all.yml need to have quarto rendering capabilities.

I am building this here but the tru test for these GHA updates will be done over here: fhdsl/OTTR_Quarto#20

Related fhdsl/OTTR_Quarto#2

Copy link
Contributor

github-actions bot commented Apr 18, 2024

No broken url errors! 🎉
Comment updated at 2024-06-28-20:13:47 with changes from 6ef418f

Copy link
Contributor

github-actions bot commented Apr 18, 2024

No spelling errors! 🎉
Comment updated at 2024-06-28-20:13:47 with changes from 6ef418f

Copy link
Contributor

github-actions bot commented Apr 18, 2024

Re-rendered previews from the latest commit:

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2024-06-28 with changes from the latest commit 6ef418f

@howardbaik
Copy link
Contributor

howardbaik commented Apr 19, 2024

How do I use this repo's Actions in .github/workflows/render-all.yml inside https://github.com/fhdsl/ottr?

@cansavvy
Copy link
Collaborator Author

For now you can copy it over after it's ready.

But then long term we'll have to add the ottr repo to the sync.yml file so it is updated

@cansavvy cansavvy changed the title Make render-all.yml compatible with quarto Make GHA yml's compatible with quarto May 15, 2024
@cansavvy
Copy link
Collaborator Author

cansavvy commented May 15, 2024

Preview appears to be updating accordingly on fhdsl/OTTR_Quarto#20

@cansavvy cansavvy merged commit beb1e0d into main Jul 16, 2024
8 checks passed
@cansavvy cansavvy deleted the cansavvy/quarto-compatability branch July 16, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants